drivers: STM32 async flash erase and write #93173
Conversation
|
Hello @jpowen898, and thank you very much for your first pull request to the Zephyr project! |
jpowen898
force-pushed
the
main
branch
2 times, most recently
from
c34e153 to
ae67109
Compare
|
@nordicjm Thanks for the feedback. I made all the requested changes, let me know if there is anything else. |
jpowen898
force-pushed
the
main
branch
3 times, most recently
from
030ad53 to
df9a4f8
Compare
zephyrbot
requested review from
de-nordic,
djiatsaf-st,
FRASTM,
gautierg-st,
GeorgeCGV,
marwaiehm-st,
mathieuchopstm and
rghaddab
jpowen898
force-pushed
the
main
branch
2 times, most recently
from
9129568 to
b5d3812
Compare
| FLASH_STM32_PRIV(dev)->async_complete = false; | ||
| FLASH_STM32_PRIV(dev)->async_error = false; | ||
| HAL_FLASH_Program_IT(FLASH_TYPEPROGRAM_DOUBLEWORD, offset + FLASH_STM32_BASE_ADDRESS, val); | ||
| k_sem_take(&FLASH_STM32_PRIV(dev)->async_sem, K_FOREVER); | ||
| if (FLASH_STM32_PRIV(dev)->async_complete) { | ||
| LOG_DBG("Flash write successful. Wrote 0x%llx at 0x%lx", | ||
| val, offset + FLASH_STM32_BASE_ADDRESS); | ||
| rc = 0; | ||
| } else { | ||
| if (FLASH_STM32_PRIV(dev)->async_error) { | ||
| LOG_ERR("Flash write failed %d", FLASH_STM32_PRIV(dev)->async_ret); | ||
| } | ||
| rc = -EIO; | ||
| } |
There was a problem hiding this comment.
Break a line between code blocks.
Apply everywhere.
There was a problem hiding this comment.
I wasn't 100% sure what you were looking for but I added line breaks before #if, and after #else and #endif. Let me know if that is not what you were looking for or if you wanted line breaks before and after #else or something else.
Added optional use of the stm32 hal async flash write and erase capabilities on the l4, f4, and h7 soc families. It is implemented using semaphores to allow for other threads to take action during the erase/write actions. This feature is disabled by default and can be optionally enabled using the FLASH_STM32_ASYNC config option. Signed-off-by: Parker Owen <jpowen898@gmail.com>
|
HAL_FLASHEx_Erase_IT()andHAL_FLASH_Program_IT()functions with their associated interrupt handler.FLASH_STM32_ASYNCconfig option.