vmu_rt1170: Add axis alignment to ICM4268X with Right-Hand rule #92660
+1,680
−1,435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a first step to enable the similar variants (e.g: ICM42686), refactor common functionality into icm4268x files. As a result, applications using the icm42688 will need to have both compatible properties: "invensense,icm42688" and "invensense,icm4268x" defined. In-tree boards have been modified to comply with this pattern. This patch does not contain functional changes. The driver should work the same as before. Signed-off-by: Luis Ubieda <luisf@croxel.com>
Addressing low-hanging fruits. Put in a separate commit in order to make it easier to keep track of changes. Signed-off-by: Luis Ubieda <luisf@croxel.com>
Now this driver supports both ICM42688 and ICM42686. Tested with read-decode as well as streaming mode. Signed-off-by: Luis Ubieda <luisf@croxel.com>
When IMU is set to stream with High-res mode, the FSR settings are fixed: - ICM42688 at 16g and 2000dps. - ICM42686 at 32g and 4000dps. Unless this is enforced, the driver will provide incorrect scaling for readings coming through streaming when the current FS setting is any different than these. Signed-off-by: Luis Ubieda <luisf@croxel.com>
Additionally, remove overlay from sensor-shell sample, which is redundant. Signed-off-by: Luis Ubieda <luisf@croxel.com>
For build-time validation. Signed-off-by: Luis Ubieda <luisf@croxel.com>
Missing an inverted sign on Axis Align on X. Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com> Signed-off-by: Luis Ubieda <luisf@croxel.com>
Matches with on-board ICM42688, complying with right-hand rule. Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com> Signed-off-by: Luis Ubieda <luisf@croxel.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sits on top of #92579 to add Axis Alignment to the VMU RT1170 so both on-board IMUs are aligned (ICM42686 and ICM42688).
This patch was co-authored by @bperseghetti
Note
Marking this PR as DNM until #92579 is merged.