Skip to content

drivers: sensor: wsen_isds_2536030320001: add sensor driver #92517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wm-eisos
Copy link
Contributor

@wm-eisos wm-eisos commented Jul 2, 2025

Add wsen_isds_2536030320001 driver and compatibility with the hal update as well as added new features.

This PR is a continuation of the closed PR #62408

@mah-eiSmart
@MaureenHelm
@kartben I think code formatting is failing due to clang-format causing macros to have lines lengths longer than the allowed limit. Last time i believe you fixed somehow in this PR #86213 can you please fix it again here?

@wm-eisos
Copy link
Contributor Author

wm-eisos commented Jul 7, 2025

@kartben can you please check this out? also i guess since it was added to the 4.3.0 milestone i should update the releases notes to 4.3

@kartben
Copy link
Collaborator

kartben commented Jul 7, 2025

@kartben can you please check this out? also i guess since it was added to the 4.3.0 milestone i should update the releases notes to 4.3

Yeah just drop the release notes update altogether since this list is auto populated based on bindings added between releases. This will reduce the likelihood of having merge calls conflicts

@wm-eisos
Copy link
Contributor Author

wm-eisos commented Jul 7, 2025

@kartben can you please check this out? also i guess since it was added to the 4.3.0 milestone i should update the releases notes to 4.3

Yeah just drop the release notes update altogether since this list is auto populated based on bindings added between releases. This will reduce the likelihood of having merge calls conflicts

Okay sounds good will do can you please fix the thing with the compliance checks?

@kartben
Copy link
Collaborator

kartben commented Jul 7, 2025

Okay sounds good will do can you please fix the thing with the compliance checks?

LOL that's your code, what should I be fixing? :)

image

@wm-eisos
Copy link
Contributor Author

wm-eisos commented Jul 7, 2025

Okay sounds good will do can you please fix the thing with the compliance checks?

LOL that's your code, what should I be fixing? :)

image

As i mentioned last time you fixed it due to the reason that clang-format results in a formatted file that doesn't pass compliance checks. I mean ideally it would be even better if the clang-format configuration was fixed so that we don't have to deal with this

@wm-eisos
Copy link
Contributor Author

wm-eisos commented Jul 7, 2025

i will take a look but this is clearly an issue due to a mismatch between clang-format and the CI checks

@kartben
Copy link
Collaborator

kartben commented Jul 7, 2025

As i mentioned last time you fixed it due to the reason that clang-format results in a formatted file that doesn't pass compliance checks

I just manually formatted your code, if I remember correctly
https://github.com/zephyrproject-rtos/zephyr/compare/0acdcf65ad41adfc2d6a050fc837526666e0d5a0..666566df339e382f14f2f3be80df8efd89d4a5b3

@kartben
Copy link
Collaborator

kartben commented Jul 7, 2025

i will take a look but this is clearly an issue due to a mismatch between clang-format and the CI checks

clang format may have bugs -- here the code's formatting clearly looks very off and not desirable at all so it makes sense to fix it, wouldn't you agree?

@wm-eisos
Copy link
Contributor Author

wm-eisos commented Jul 7, 2025

i will take a look but this is clearly an issue due to a mismatch between clang-format and the CI checks

clang format may have bugs -- here the code's formatting clearly looks very off and not desirable at all so it makes sense to fix it, wouldn't you agree?

Yes i do the issue that i had was basically i was fixing the formatting and then the compliance checks will check if its formatted with clang-format and if i do run clang-format then they are longer than 100 columns. I will fix it for this one if i can but it would be nice if we can find a solution to that issue because im sure other will also get this as well.

@wm-eisos wm-eisos force-pushed the wsen_isds_2536030320001 branch 2 times, most recently from 2c85b3a to 285ceb0 Compare July 7, 2025 11:23
Add wsen_isds_2536030320001 driver with
the corrected name and compatibility with
the hal update as well as added new features.

Signed-off-by: Wajdi ELMuhtadi <wajdi.elmuhtadi@we-online.com>
@wm-eisos wm-eisos force-pushed the wsen_isds_2536030320001 branch from 285ceb0 to 46d4b36 Compare July 7, 2025 11:33
Copy link

sonarqubecloud bot commented Jul 7, 2025

@wm-eisos
Copy link
Contributor Author

wm-eisos commented Jul 7, 2025

@kartben i just fixed if you can merge this one it would be nice as we already have another driver prepared as well.

@kartben
Copy link
Collaborator

kartben commented Jul 7, 2025

@kartben i just fixed if you can merge this one it would be nice as we already have another driver prepared as well.

The PR needs to be reviewed and approved first. And we're in feature freeze for 4.2 anyway so this won't be merged until 4.3 merge window opens in about 3 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Sensors Sensors Release Notes To be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants