boards: shields: add support for rtk0eg0019b01002bj #92434
Conversation
Update rev of hal_renesas to add support for CTSU Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
bot
added
manifest
manifest-hal_renesas
DNM (manifest)
There was a problem hiding this comment.
as other PR, this is 130KiB of images
There was a problem hiding this comment.
You can run them through cwebp https://developers.google.com/speed/webp/docs/precompiled
| board_set_debugger_ifnset(jlink) | ||
| board_set_flasher_ifnset(jlink) |
There was a problem hiding this comment.
drop, these are part of the *.board.cmake files below already
There was a problem hiding this comment.
You can run them through cwebp https://developers.google.com/speed/webp/docs/precompiled
| #ifndef ZEPHYR_INCLUDE_ZEPHYR_INPUT_INPUT_RENESAS_RA_CTSU_H_ | ||
| #define ZEPHYR_INCLUDE_ZEPHYR_INPUT_INPUT_RENESAS_RA_CTSU_H_ | ||
|
|
||
| #include "rm_touch.h" |
There was a problem hiding this comment.
should probably be #include <rm_touch.h>, normally this format is for files in the same directory
| * @retval -ENOSYS in case INPUT_RENESAS_RA_QE_TOUCH_CFG was not enabled | ||
| * @retval -errno on failure | ||
| */ | ||
| __syscall int renesas_ra_ctsu_group_configure(const struct device *dev, |
There was a problem hiding this comment.
does it need to be a syscall? you really want the userspace to configure it?
| elements = <0>, <3>, <2>, <1>; | ||
| threshold = <711>; | ||
| event-code = <INPUT_ABS_WHEEL>; | ||
| status = "okay"; |
There was a problem hiding this comment.
nodes are "okay" by default, no point specifying this in the example, this is designed to be instantiated on the board so this is redundant, same for the other ones
| #define K_POLLING K_MSEC(CONFIG_INPUT_RENESAS_RA_CTSU_POLLING_INTERVAL_MS) | ||
| #define K_STABILIZATION K_USEC(CONFIG_INPUT_RENESAS_RA_CTSU_STABILIZATION_TIME_US) | ||
|
|
||
| static ALWAYS_INLINE void renesas_ra_ctsu_drv_handler(void *arg0) |
There was a problem hiding this comment.
why always inline? I'd imagine the compiler is smart enough to optimize it by itself
the argument should probably just be aconst struct device * no point keep casting it back and forth
| static void renesas_ra_ctsu_thread##inst(void *dev, void *arg1, void *arg2) \ | ||
| { \ | ||
| ARG_UNUSED(arg1); \ | ||
| ARG_UNUSED(arg2); \ | ||
| renesas_ra_ctsu_drv_handler(dev); \ | ||
| } \ |
There was a problem hiding this comment.
why not just use renesas_ra_ctsu_drv_handler as argument for k_thread_create? there's no references to inst in the body
| #define K_POLLING K_MSEC(CONFIG_INPUT_RENESAS_RA_CTSU_POLLING_INTERVAL_MS) | ||
| #define K_STABILIZATION K_USEC(CONFIG_INPUT_RENESAS_RA_CTSU_STABILIZATION_TIME_US) |
There was a problem hiding this comment.
I think K_ is the prefix for kernel function, no need to use it here, makes it sound like these are project-wide defines which they are not
| This binding provides resources required for the LED matrix | ||
| on the RTK0EG0019B01002BJ board. | ||
|
|
||
| compatible: "rtk0eg0019b01002bj-led-matrix" |
| /************************************************************************************************** | ||
| * File Name : qe_touch_config.c | ||
| * Description : This file includes module implementations. | ||
| **************************************************************************************************/ | ||
| /************************************************************************************************** | ||
| * History : MM/DD/YYYY Version Description | ||
| * : 09/02/2019 1.00 First Release | ||
| * : 10/07/2019 1.00a Provisional Version for RA2L1 | ||
| * : 12/26/2019 1.10 Corresponding for FSP V0.10.0 | ||
| * : 02/20/2020 1.20 Corresponding for FSP V0.12.0 | ||
| * : 02/26/2020 1.21 Adding information for Temperature Correction | ||
| * : 03/04/2020 1.30 Corresponding for FSP V1.0.0 RC0 | ||
| * : 03/10/2020 1.31 Corresponding for FSP V1.0.0 RC1 | ||
| * : 09/10/2020 1.40 Corresponding for FSP V2.0.0 Beta2 | ||
| * : 05/26/2021 1.50 Adding Diagnosis Supporting | ||
| * : 06/01/2021 1.51 Fixing a Little | ||
| * : 07/15/2021 1.52 Fixing a Little | ||
| * : 08/20/2021 1.53 Fixing a Little | ||
| * : 11/13/2021 1.60 Adding information for Initial Offset Tuning | ||
| * : 03/31/2023 1.61 Improving Traceability | ||
| * : 04/18/2023 1.70 Adding 3 Frequency Judgement Supporting | ||
| * : 07/30/2024 1.80 Adding Auto Judgement Supporting | ||
| **************************************************************************************************/ | ||
| /************************************************************************************************** | ||
| * Touch I/F Configuration File : quickstart_rssk_ra2l1_ep.tifcfg | ||
| * Tuning Log File : quickstart_rssk_ra2l1_ep_log_tuning20230904134024.log | ||
| **************************************************************************************************/ |
There was a problem hiding this comment.
these are not very relevant and very confusing, is this file generated? Just point that out
thenguyenyf
force-pushed
the
renesas_rtk0eg0019b01002bj_shield_support
branch
3 times, most recently
from
a2f9729 to
5d3ce19
Compare
First commit to add support for Renesas RA Capasitive Sensing Unit Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
Add CTSU pin function selection for Renesas RA devices Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
Add device node support for Renesas RA SoCs Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
Enable support for CTSU button on ek_ra2a1 board Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
First commit to initial support for RSSK-RA2L1 Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
First commit to initial support for RSSK-RA2L1 Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
Add Capacitive Touch Application Board RTK0EG0019B01002BJ Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
This commit to enable rssk_ra2l1 build with rtk0eg0019b01002bj shield. Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
First commit to add rtk0eg0019b01002bj shield sample Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>
thenguyenyf
force-pushed
the
renesas_rtk0eg0019b01002bj_shield_support
branch
from
5d3ce19 to
3fc788c
Compare
|
This PR to add support for Renesas RTK0EG0019B01002BJ Capacitive Application shield
Signed-off-by: The Nguyen the.nguyen.yf@renesas.com