drivers: input: add support for Renesas CTSU #92433

thenguyenyf · 2025-07-01T07:39:10Z

This PR to add Input subsys support on Renesas CTSU HWIP

Update rev of hal_renesas to add support for CTSU Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>

github-actions · 2025-07-01T07:40:32Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_renesas	zephyrproject-rtos/hal_renesas@`0769fe1`	zephyrproject-rtos/hal_renesas#115	zephyrproject-rtos/hal_renesas#115/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

fabiobaltieri · 2025-07-01T14:36:05Z

Woops, added few comments on #92434, should have probably done it here, could you pick the initial comments from there? Sorry for the confusion.

thenguyenyf

@fabiobaltieri Move conversion from #92434 due to this PR should be the correct place for review

include/zephyr/input/input_renesas_ra_ctsu.h

thenguyenyf · 2025-07-02T03:17:24Z

dts/bindings/input/renesas,ra-ctsu-button.yaml

+        threshold = <769>;
+        hysteresis = <38>;
+        event-code = <INPUT_KEY_0>;
+        status = "okay";


#92434 (comment)

I understood that a status = "okay"; is not necessary in the node example for documentation, right? If its correct, I will remove it

It's also not necessary in the first place unless you are overriding a node that has been defined with status disabled, typically these would be the basic SoC device nodes defined under soc/ and enabled from boards/, but for these pseudo-device node things that are defined in board without overriding anything you don't need to set the status, they are enabled by default

understood. I will remove the status from the documentation and the board/shield dts

drivers/input/Kconfig.renesas_ra

thenguyenyf · 2025-07-02T03:30:52Z

drivers/input/input_renesas_ra_ctsu.c

+#define K_POLLING       K_MSEC(CONFIG_INPUT_RENESAS_RA_CTSU_POLLING_INTERVAL_MS)
+#define K_STABILIZATION K_USEC(CONFIG_INPUT_RENESAS_RA_CTSU_STABILIZATION_TIME_US)
+
+static ALWAYS_INLINE void renesas_ra_ctsu_drv_handler(void *arg0)


#92434 (comment)
#92434 (comment)

I refer it from some skeleton code that exist in Zephyr repo (ex: udc_skeleton.c). So, if it's not good/suitable for this driver, I will change as your suggestion.

wouldn't bother unless you know that it is actually making a difference

so back on this one, I'd suggest

drop the ALWAYS_INLINE

add the extra 2 dummy argument, drop the renesas_ra_ctsu_thread##inst generated wrapper and call this directly from k_thread_create

fabiobaltieri · 2025-07-02T09:21:55Z

Thanks for porting the comments over from the other PR

fabiobaltieri · 2025-07-08T10:10:30Z

drivers/input/input_renesas_ra_ctsu.c

+	};                                                                                         \
+                                                                                                   \
+	DEVICE_DT_INST_DEFINE(inst, ctsu_device_init, NULL, NULL, &ctsu_button_cfg##inst,          \
+			      POST_KERNEL, CONFIG_INPUT_INIT_PRIORITY, NULL);))


are you formatting manually? I'd move the )) down a line and at the same indentation as the IF_ENABLED, this is a bit hard to follow as it is

fabiobaltieri · 2025-07-08T10:12:21Z

drivers/input/input_renesas_ra_ctsu.c

+#define K_POLLING       K_MSEC(CONFIG_INPUT_RENESAS_RA_CTSU_POLLING_INTERVAL_MS)
+#define K_STABILIZATION K_USEC(CONFIG_INPUT_RENESAS_RA_CTSU_STABILIZATION_TIME_US)
+
+static ALWAYS_INLINE void renesas_ra_ctsu_drv_handler(void *arg0)


so back on this one, I'd suggest

drop the ALWAYS_INLINE

add the extra 2 dummy argument, drop the renesas_ra_ctsu_thread##inst generated wrapper and call this directly from k_thread_create

fabiobaltieri · 2025-07-08T10:15:33Z

drivers/input/input_renesas_ra_ctsu.c

+	static void renesas_ra_ctsu_make_thread##inst(const struct device *dev)                    \
+	{                                                                                          \
+		struct renesas_ra_ctsu_data *data = dev->data;                                     \
+                                                                                                   \
+		k_thread_create(&data->thread_data, renesas_ra_ctsu_drv_stack##inst,               \
+				K_THREAD_STACK_SIZEOF(renesas_ra_ctsu_drv_stack##inst),            \
+				renesas_ra_ctsu_thread##inst, (void *)dev, NULL, NULL,             \
+				K_PRIO_COOP(CTSU_DRV_THREAD_PRIORITY), K_ESSENTIAL, K_NO_WAIT);    \
+		k_thread_name_set(&data->thread_data, dev->name);                                  \
+	}                                                                                          \


no need for this wrapper, declare the stack as part of renesas_ra_ctsu_data and move this code directly in renesas_ra_ctsu_init, you can check out input_analog_axis.c for reference

Done. I moved stack memory into data structure.

fabiobaltieri · 2025-07-08T10:15:45Z

drivers/input/input_renesas_ra_ctsu.c

+	PINCTRL_DT_INST_DEFINE(inst);                                                              \
+	K_THREAD_STACK_DEFINE(renesas_ra_ctsu_drv_stack##inst, CTSU_DRV_THREAD_STACK_SIZE);        \
+                                                                                                   \
+	static void renesas_ra_ctsu_thread##inst(void *dev, void *arg1, void *arg2)                \


no need for this wrapper, see the comment above

Done. The thread creation was called directly in init() function.

fabiobaltieri · 2025-07-08T10:20:47Z

drivers/input/input_renesas_ra_ctsu.c

+	const struct ctsu_device_cfg *cfg = dev->config;
+	uint16_t *p_data = data;
+
+	if (p_data != NULL) {


swap the condition, normal execution inline

if (p_data == NULL) { return; } input_report_abs(...);

fabiobaltieri · 2025-07-08T10:26:19Z

drivers/input/input_renesas_ra_ctsu.c

+	if (cfg->num_button > 0) {
+		if (*data->p_button_status != 0) {
+			uint64_t tmp_status = *data->p_button_status;
+
+			while (tmp_status != 0) {
+				int num = u64_count_trailing_zeros(tmp_status);
+				struct renesas_ra_ctsu_device_cb *p_button_cb =
+					&data->p_button_cb[num];
+
+				p_button_cb->device_cb(p_button_cb->dev, NULL);
+				WRITE_BIT(tmp_status, num, 0);
+			}
+		}
+	}


how about refactoring this and the two below in their own functions? flag those as maybe_unused, have an early return for

if (cfg->num_button == 0) { return; }

so you have one less indentation level

Done. 3 new reading function was created for buttons, wheels and sliders

First commit to add support for Renesas RA Capasitive Sensing Unit Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>

Add CTSU pin function selection for Renesas RA devices Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>

Add device node support for Renesas RA SoCs Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>

Enable support for CTSU button on ek_ra2a1 board Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>

sonarqubecloud · 2025-07-14T04:44:03Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

fabiobaltieri

just a couple more comments, then I guess this is waiting for the hal PR to be reviewed, can you get it approved by someone else working on renesas? then I can merge it

fabiobaltieri · 2025-07-16T08:55:36Z

drivers/input/input_renesas_ra_ctsu.c

+{
+	ARG_UNUSED(arg1);
+	ARG_UNUSED(arg2);
+	const struct device *ctsu_dev = (const struct device *)arg0;


no need for the casting, arg0 is a void * there's nothing the compiler can check for you

fabiobaltieri · 2025-07-16T09:02:22Z

drivers/input/input_renesas_ra_ctsu.c

+#if DT_HAS_COMPAT_STATUS_OKAY(renesas_ra_ctsu_slider)
+static void renesas_ra_ctsu_group_sliders_read(const struct device *dev)
+{
+	const struct renesas_ra_ctsu_group_cfg *cfg = dev->config;
+	struct renesas_ra_ctsu_group_data *data = dev->data;
+
+	if (cfg->num_slider == 0) {
+		return;
+	}
+
+	for (int i = 0; i < cfg->num_slider; i++) {
+		uint16_t slider_position = data->p_slider_position[i];
+
+		if (slider_position != UINT16_MAX) {
+			struct renesas_ra_ctsu_device_cb *p_slider_cb = &data->p_slider_cb[i];
+
+			p_slider_cb->device_cb(p_slider_cb->dev, &slider_position);
+		}
+	}
+}
+#endif /* DT_HAS_COMPAT_STATUS_OKAY(renesas_ra_ctsu_slider) */


move the #if condition inside the function body and let it be a no-op when this is not enabled, then you can remove the conditionals from renesas_ra_ctsu_group_reading_handler and always call these, they'll just get optimized out when they are not needed

manifest: update hal_renesas revision to latest

275a84b

Update rev of hal_renesas to add support for CTSU Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>

github-actions bot added area: Input Input Subsystem and Drivers area: Pinctrl platform: Renesas RA Renesas Electronics Corporation, RA labels Jul 1, 2025

github-actions bot requested review from duynguyenxa, fabiobaltieri, gmarull, KhiemNguyenT, soburi and thaoluonguw July 1, 2025 07:40

github-actions bot assigned fabiobaltieri Jul 1, 2025

github-actions bot added manifest manifest-hal_renesas DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jul 1, 2025

thenguyenyf mentioned this pull request Jul 1, 2025

boards: shields: add support for rtk0eg0019b01002bj #92434

Draft

thenguyenyf force-pushed the renesas_ra_ctsu_driver_support branch from 203be5e to c26a69a Compare July 1, 2025 09:29

thenguyenyf commented Jul 2, 2025

View reviewed changes

thenguyenyf force-pushed the renesas_ra_ctsu_driver_support branch from c26a69a to 2d79335 Compare July 4, 2025 06:31

fabiobaltieri reviewed Jul 8, 2025

View reviewed changes

thenguyenyf force-pushed the renesas_ra_ctsu_driver_support branch 2 times, most recently from 5331c27 to 07d5949 Compare July 14, 2025 03:42

thenguyenyf added 4 commits July 14, 2025 11:17

drivers: input: initial support for renesas,ra-ctsu

6964578

First commit to add support for Renesas RA Capasitive Sensing Unit Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>

bindings: pinctrl: add ctsu psel selection for Renesas RA

e24d5f3

Add CTSU pin function selection for Renesas RA devices Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>

dts: arm: renesas: add CTSU device node for Renesas RA

5be3778

Add device node support for Renesas RA SoCs Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>

boards: renesas: ek_ra2a1: add support for ctsu on Renesas RA

0c1eaa3

Enable support for CTSU button on ek_ra2a1 board Signed-off-by: The Nguyen <the.nguyen.yf@renesas.com>

thenguyenyf force-pushed the renesas_ra_ctsu_driver_support branch from 07d5949 to 0c1eaa3 Compare July 14, 2025 04:17

fabiobaltieri reviewed Jul 16, 2025

View reviewed changes

drivers: input: add support for Renesas CTSU #92433

Are you sure you want to change the base?

drivers: input: add support for Renesas CTSU #92433

Conversation

thenguyenyf commented Jul 1, 2025

Uh oh!

github-actions bot commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabiobaltieri commented Jul 1, 2025

Uh oh!

thenguyenyf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fabiobaltieri commented Jul 2, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jul 14, 2025

Quality Gate passed

Uh oh!

fabiobaltieri left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jul 1, 2025 •

edited

Loading