zephyr: sw_isr_table: Fix compilation error #92336
Open
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thughes
force-pushed
the
push-tkksrrryqvwy
branch
2 times, most recently
from
520d877 to
cbd2158
Compare
The IRQ_DIRECT_CONNECT macro eventually uses _Z_ISR_DIRECT_TABLE_ENTRY, which defines a function. IRQ_DIRECT_CONNECT is meant to be used inside functions. While nested functions are supported as an extension in GNU C, the nested function cannot have static storage. https://gcc.gnu.org/onlinedocs/gcc/Nested-Functions.html: > A nested function always has no linkage. Declaring one with extern or > static is erroneous. ./scripts/twister -c -s arch.interrupt.gen_isr_table_local.riscv --all tests/kernel/gen_isr_table/src/main.c: In function 'gen_isr_table_test_build_time_direct_interrupt': include/zephyr/sw_isr_table.h:197:41: error: invalid storage class for function '__isr_table_entry_isr1_irq_2' #define __MK_ISR_ELEMENT_NAME(func, id) __isr_table_entry_ ## func ## _irq_ ## id ^~~~~~~~~~~~~~~~~~ Issue zephyrproject-rtos#92194 Signed-off-by: Tom Hughes <tomhughes@chromium.org>
thughes
force-pushed
the
push-tkksrrryqvwy
branch
from
cbd2158 to
cd0f613
Compare
thughes
commented
Jun 30, 2025
| static void __attribute__((section(sect))) __attribute__((naked)) \ | ||
| __used _MK_IRQ_ELEMENT_NAME(func, __COUNTER__)(void) { \ | ||
| void __attribute__((section(sect))) __attribute__((naked)) \ | ||
| /* clang-format off */ \ |
There was a problem hiding this comment.
I had to turn off clang-format here because it wanted to make line 248 and 249 a single line, which breaks the other check that lines are shorter than 100 characters.
There was a problem hiding this comment.
good thing, that clang-format isn't mandatory
1 task
|
maass-hamburg
approved these changes
Jul 1, 2025
maass-hamburg
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IRQ_DIRECT_CONNECT macro eventually uses _Z_ISR_DIRECT_TABLE_ENTRY,
which defines a function. IRQ_DIRECT_CONNECT is meant to be used
inside functions. While nested functions are supported as an extension
in GNU C, the nested function cannot have static storage.
https://gcc.gnu.org/onlinedocs/gcc/Nested-Functions.html:
Issue #92194