drivers: udc: rpi_pico: fix RP2350 warm ep init #91905
Open
+22
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Tested with webusb-next, console-next and midi samples, all seem functional |
jfischer-no
requested changes
Jun 20, 2025
Move control endpoint enable/disable calls to udc_enable()/udc_disable(). It does not change much during USB device support initialization, but it seems to resolve an issue when starting from RAM, though the real cause is unknown. Signed-off-by: Dmitrii Sharshakov <d3dx12.xx@gmail.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue that RP2350's USB controller won't start after a boot
through bootloader (for example a RAM-only boot)
For some reason this could be worked around by a k_usleep(10) added to
the enable function, however it was discovered that endpoint setup was
in the init function and not in enable function.
This led to DPSRAM likely being in the wrong state, as the enable path
zeroes its contents.
Fixed by moving internal endpoint enable/disable into enable/disable
from init/shutdown. This is done the same way in the
nrf, samd, dwc2 and stm32 drivers.
This also matches init sequency tinyusb does more closely.
Signed-off-by: Dmitrii Sharshakov d3dx12.xx@gmail.com