Skip to content

drivers: display: st: allow-ltdc-callback-override #91750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −2
Open

drivers: display: st: allow-ltdc-callback-override #91750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions drivers/display/display_stm32_ltdc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
* Copyright (c) 2022 Byte-Lab d.o.o. <dev@byte-lab.com>
* Copyright 2023 NXP
* Copyright (c) 2024 STMicroelectronics
* Copyright (c) 2025 STMicroelectronics
*
* SPDX-License-Identifier: Apache-2.0
*/
Expand All @@ -28,6 +28,8 @@
#include <zephyr/logging/log.h>
LOG_MODULE_REGISTER(display_stm32_ltdc, CONFIG_DISPLAY_LOG_LEVEL);

#include "display_stm32_ltdc.h"

/* Horizontal synchronization pulse polarity */
#define LTDC_HSPOL_ACTIVE_LOW 0x00000000
#define LTDC_HSPOL_ACTIVE_HIGH 0x80000000
Expand Down Expand Up @@ -84,7 +86,7 @@ struct display_stm32_ltdc_config {
const struct device *display_controller;
};

static void stm32_ltdc_global_isr(const struct device *dev)
void __weak stm32_ltdc_global_isr(const struct device *dev)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes would need stm32_ltdc_global_isr() to be declared in a header file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I don't know how this ever worked in my testing. I've added a .h file included in the driver.

{
struct display_stm32_ltdc_data *data = dev->data;

Expand Down
12 changes: 12 additions & 0 deletions drivers/display/display_stm32_ltdc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
/*
* Copyright 2025, STMicroelectronics
*
* SPDX-License-Identifier: Apache-2.0
*/

#ifndef _ZEPHYR_DRIVERS_DISPLAY_STM32_LTDC_H_
#define _ZEPHYR_DRIVERS_DISPLAY_STM32_LTDC_H_

void stm32_ltdc_global_isr(const struct device *dev);

#endif /* _ZEPHYR_DRIVERS_DISPLAY_STM32_LTDC_H_ */
Loading