-
Notifications
You must be signed in to change notification settings - Fork 7.7k
drivers: display: st: allow-ltdc-callback-override #91750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
drivers: display: st: allow-ltdc-callback-override #91750
Conversation
Hi @markussmST,
|
I was considering that solution as well, with the addition of a return from that function to determine if the existing code should be executed. |
@@ -84,7 +84,7 @@ struct display_stm32_ltdc_config { | |||
const struct device *display_controller; | |||
}; | |||
|
|||
static void stm32_ltdc_global_isr(const struct device *dev) | |||
void __weak stm32_ltdc_global_isr(const struct device *dev) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes would need stm32_ltdc_global_isr()
to be declared in a header file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I don't know how this ever worked in my testing. I've added a .h file included in the driver.
9b958fb
to
cc3fe73
Compare
Allow overriding the LTDC callback for manual handling or extension In some cases, the default handling may not be desired, for example triggering handling of the next frame/block once the transfer has passed a certain line. Signed-off-by: Mathias Markussen <mathias.markussen@st.com>
cc3fe73
to
ee22fff
Compare
|
Allow overriding the LTDC callback for manual handling or extension In some cases, the default handling may not be desired, for example triggering handling of the next frame/block once the transfer has passed a certain line.