Skip to content

Adding SOC WCH ch32v307 and board scdz ch32v307evt #91702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SoftwareArchitekt
Copy link

Adding SOC WCH ch32v307 and board scdz ch32v307evt
all remarks from old request are included

@@ -18,9 +18,11 @@ GTEXT(__initialize)

SECTION_FUNC(vectors, ivt)
.option norvc
#ifndef SOC_CH32V307
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove these two lines, you have to change the value written into mtvec (to 0x7 in this case).

@nordicjm nordicjm requested a review from kartben June 17, 2025 09:15
@miggazElquez
Copy link
Contributor

When pushing modification, you should rebase your changes to keep only the necessary commits and force push. See https://docs.zephyrproject.org/latest/contribute/guidelines.html#contribution-workflow, 14th bullet point.

@miggazElquez
Copy link
Contributor

Which commit you mean?

At first your pull request had two commits, and it was correct. But you pushed two new commits, and these two new commits shouldn't appear, they should be squashed into the first two commit. The contribution guideline will explain this better than me

@SoftwareArchitekt
Copy link
Author

Which commit you mean?

At first your pull request had two commits, and it was correct. But you pushed two new commits, and these two new commits shouldn't appear, they should be squashed into the first two commit. The contribution guideline will explain this better than me

I have done, pls. check

dts: add riscv/wch/ch32v307 and packages

wch has provide a ch32v307 soc series

Signed-off-by: Thomas Boje <info@andocs.biz>
adding from scdz the ch32v307evt-board, it is build on a ch32v307vc-soc
which have a risc-v qingKeV4F-Core

Signed-off-by: Thomas Boje <info@andocs.biz>
Copy link

sonarqubecloud bot commented Jul 2, 2025

@@ -0,0 +1,12 @@
identifier: scdz_ch32v307evt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
identifier: scdz_ch32v307evt
identifier: ch32v307evt

this should fix the CI error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants