drivers: flash: Clarify parameter validation order #90706
+37
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Flash
platform: NXP S32
github-actions
bot
requested review from
congnguyenhuu,
Dat-NguyenDuy,
dbaluta,
decsny,
manuargue,
mmahadevan108,
Raymond0225 and
rghaddab
dleach02
changed the title
Add some clarity on expected parameter validation order to have consistency between implementations. Signed-off-by: David Leach <david.leach@nxp.com>
Parameter checking of flash read API expects checking for len == 0 before checking dest buffer validation. Fixes zephyrproject-rtos#87021 Signed-off-by: David Leach <david.leach@nxp.com>
de-nordic
reviewed
May 28, 2025
| return 0; | ||
| } | ||
|
|
||
| if (!buffer) { |
There was a problem hiding this comment.
Not compliant with Coding Guidelines, Zephyr rule 85 (https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_14_04.c), should be buffer == NULL.
There was a problem hiding this comment.
OK, now I see that the entire driver keeps that style, so the decision is on you.
de-nordic
approved these changes
May 28, 2025
|
kartben
approved these changes
May 29, 2025
|
To avoid losing the +1 I'm going to follow up this PR with a new one that will just align to the coding guideline @de-nordic pointed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some clarity on expected parameter validation order to have
consistency between implementations.
Update NXP flash drivers to align with parameter validation order
Fixes #87021
Signed-off-by: David Leach david.leach@nxp.com