Samples: Introduce device_deinit() sample
#89927
Open
+458
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjarki-andreasen
changed the title
device_deinit() sample
bjarki-andreasen
force-pushed
the
nrfx-spim-deinit
branch
from
23af243 to
4b2375f
Compare
github-actions
bot
added
area: Samples
github-actions
bot
requested review from
aasinclair,
anangl,
dbaluta,
decsny,
dleach02,
jaz1-nordic,
kartben,
manuargue,
masz-nordic,
mmahadevan108,
nashif,
nordic-auko,
Raymond0225,
tbursztyka and
teburd
|
Note I'm all for chaning the name of the sample and its location :) |
Add DEVICE_DEINIT variants of SPI_DEVICE_ macros. These include - SPI_DEVICE_DT_DEINIT_DEFINE() - SPI_DEVICE_DT_INST_DEINIT_DEFINE() Signed-off-by: Bjarki Arge Andreasen <bjarki.andreasen@nordicsemi.no>
Implement device deinit fn for nrf spim device driver. Signed-off-by: Bjarki Arge Andreasen <bjarki.andreasen@nordicsemi.no>
Implement deinit op in spi_nrfx_spi.c Signed-off-by: Bjarki Arge Andreasen <bjarki.andreasen@nordicsemi.no>
Introduce clearirqhandler which clears the irq handler of a peripheral. Useful for device_deinit(). Signed-off-by: Bjarki Arge Andreasen <bjarki.andreasen@nordicsemi.no>
Implement deinit op for NXP LPSPI device driver. Signed-off-by: Bjarki Arge Andreasen <bjarki.andreasen@nordicsemi.no>
Introduce device deinit sample which demonstrates how to share hardware resources between application and device drivers using device_deinit(), specifically between a GPIO port and SPI peripheral. Signed-off-by: Bjarki Arge Andreasen <bjarki.andreasen@nordicsemi.no>
bjarki-andreasen
force-pushed
the
nrfx-spim-deinit
branch
from
4b2375f to
e34168b
Compare
|
kartben
requested changes
Jun 25, 2025
| */ | ||
|
|
||
| &pinctrl { | ||
| lpuart0_default: lpuart0_default { |
There was a problem hiding this comment.
Suggested change
| lpuart0_default: lpuart0_default { | |
| lpspi0_default: lpspi0_default { |
| }; | ||
|
|
||
| &lpspi0 { | ||
| pinctrl-0 = <&lpuart0_default>; |
There was a problem hiding this comment.
Suggested change
| pinctrl-0 = <&lpuart0_default>; | |
| pinctrl-0 = <&lpspi0_default>; |
Comment on lines
+1
to
+4
| .. zephyr:code-sample:: deinit | ||
| :name: Device deinit | ||
| :relevant-api: gpio_interface spi_interface device_model | ||
|
|
There was a problem hiding this comment.
Suggested change
| .. zephyr:code-sample:: deinit | |
| :name: Device deinit | |
| :relevant-api: gpio_interface spi_interface device_model | |
| .. zephyr:code-sample:: deinit | |
| :name: Device deinitialization | |
| :relevant-api: gpio_interface spi_interface device_model | |
| Initialize and deinitialize device drivers at runtime. | |
nvlsianpu
approved these changes
Jun 30, 2025
nvlsianpu
reviewed
Jun 30, 2025
|
|
||
| static int spi_nrfx_deinit(const struct device *dev) | ||
| { | ||
| return 0; |
There was a problem hiding this comment.
I think that when CONFIG_PM_DEVICE=n this function should actually call spim_suspend(dev);
There was a problem hiding this comment.
100% agree, this PR is a bit out of date, see
zephyr/drivers/spi/spi_nrfx_spim.c
Lines 769 to 788 in ad4c3e3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce sample which switches ownership of a pin between a GPIO controller and a SPI controller driver, specifically the CS. This specific usecase has been requested before to be able to monitor the CS pin using GPIO to then wake up and switch to SPI when asserted. Its also a generally useful and portable sample of
device_deinit(),device_init()and deferred init.With this, the SPI API is updated with new headers for the _DEINIT variants of SPI_DEVICE_DT_DEFINE, and select SPI device drivers are updated to implement device deinit, drivers for the nRF SPI, nRF SPIM, and NXP LPSPI