espi/it8xxx2: waiting till completion of VW send to host #89703
+55
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
albertofloyd,
brockus-zephyr,
GTLin08,
jackrosenthal,
jvasanth1,
keith-zephyr,
RuibinChang,
sjg20 and
VenkatKotakonda
|
drivers/espi/espi_it8xxx2.c
Outdated
| VW_CHAN(ESPI_VWIRE_SIGNAL_SLP_LAN, 0x42, BIT(0), BIT(4), 0), | ||
| VW_CHAN(ESPI_VWIRE_SIGNAL_HOST_C10, 0x47, BIT(0), BIT(4), 0), | ||
| VW_CHAN(ESPI_VWIRE_SIGNAL_DNX_WARN, 0x4a, BIT(1), BIT(5), 0), | ||
| VW_CHAN(ESPI_VWIRE_SIGNAL_PME, 0x04, BIT(3), BIT(7), 0xe1), |
There was a problem hiding this comment.
Please define register names for these offsets.
drivers/espi/espi_it8xxx2.c
Outdated
Comment on lines
729
to
1322
| while ((vw_reg->VW_INDEX[vw_index] != | ||
| sys_read8(config->base_espi_vw + vw_sent)) && | ||
| timeout < IT8XXX2_ESPI_VW_SEND_TIMEOUT_MS) { | ||
| k_busy_wait(10); | ||
| timeout += 10; | ||
| } | ||
|
|
||
| if (timeout >= IT8XXX2_ESPI_VW_SEND_TIMEOUT_MS) { | ||
| LOG_WRN("VW send to host has timed out vw[0x%x] = 0x%x", | ||
| vw_index, vw_reg->VW_INDEX[vw_index]); | ||
| } |
There was a problem hiding this comment.
Suggested change
| while ((vw_reg->VW_INDEX[vw_index] != | |
| sys_read8(config->base_espi_vw + vw_sent)) && | |
| timeout < IT8XXX2_ESPI_VW_SEND_TIMEOUT_MS) { | |
| k_busy_wait(10); | |
| timeout += 10; | |
| } | |
| if (timeout >= IT8XXX2_ESPI_VW_SEND_TIMEOUT_MS) { | |
| LOG_WRN("VW send to host has timed out vw[0x%x] = 0x%x", | |
| vw_index, vw_reg->VW_INDEX[vw_index]); | |
| } | |
| if (!WAIT_FOR(vw_reg->VW_INDEX[vw_index] == sys_read8(config->base_espi_vw + vw_sent), | |
| IT8XXX2_ESPI_VW_SEND_TIMEOUT_US, k_busy_wait(10))) { | |
| LOG_WRN("VW send to host has timed out vw[0x%x] = 0x%x", | |
| vw_index, vw_reg->VW_INDEX[vw_index]); | |
| } |
keith-zephyr
previously approved these changes
May 19, 2025
AdiIntel
approved these changes
May 21, 2025
AdiIntel
reviewed
May 21, 2025
| sys_read8(config->base_espi_vw + vw_sent), | ||
| IT8XXX2_ESPI_VW_SEND_TIMEOUT_US, k_busy_wait(10))) { | ||
| LOG_WRN("VW send to host has timed out vw[0x%x] = 0x%x", | ||
| vw_index, vw_reg->VW_INDEX[vw_index]); |
There was a problem hiding this comment.
Please return -ETIMEDOUT upon failure.
There was a problem hiding this comment.
@Dino-Li this is still relevant
albertofloyd
previously approved these changes
May 21, 2025
|
heya, this needs a rebase |
Done. |
|
@albertofloyd @keith-zephyr please revisit. |
On it8xxx2, there are VW transmitted registers indicating that VW signal has been transmitted to host. This patch checks the register to ensure successful transmission of VW state change. fixes: zephyrproject-rtos#89298 Signed-off-by: Dino Li <Dino.Li@ite.com.tw>
|
fabiobaltieri
approved these changes
Jul 11, 2025
AdiIntel
approved these changes
Jul 11, 2025
GTLin08
approved these changes
Jul 11, 2025
keith-zephyr
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On it8xxx2, there are VW transmitted registers indicating that VW signal has been transmitted to host.
This patch checks the register to ensure successful transmission of VW state change.