Skip to content

Add HL78XX Modem Driver Implementation Using Modem Chat Framework #89541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

zafersn
Copy link
Contributor

@zafersn zafersn commented May 6, 2025

This pull request introduces the initial draft implementation of the HL78XX modem driver, built on the modem_chat framework. The current version establishes the core structure and essential functionality required to support the HL78XX modem series.

The primary objective at this stage is to review and align on the overall design and integration approach. Following this, development will continue with additional features such as:

  • Power saving mode support

  • User pipe connection handling

  • Other modem-specific enhancements

  • Verified compatibility and correct operation with the following sample applications:

    • aws_mqtt
    • dns_resolve
    • big_http_download
    • lwm2m

Feedback on both structure and test approach is welcome.

@rerickson1 rerickson1 self-requested a review May 6, 2025 14:48
@rerickson1 rerickson1 self-assigned this May 6, 2025
@zafersn zafersn force-pushed the hl78xx_driver branch 2 times, most recently from 31e6d9f to b1e6ffc Compare May 8, 2025 10:27
@nashif nashif requested a review from Copilot May 8, 2025 11:03
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces the initial HL78XX modem driver implementation based on the modem_chat framework while updating sample applications to integrate power management calls. Key changes include:

  • Adding power management includes and calls in sample applications to power on the modem.
  • Enhancing the modem socket poll routine with temporary POLLOUT handling.
  • Introducing new HL78XX utility and header files to support modem functionality.

Reviewed Changes

Copilot reviewed 8 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
samples/net/lwm2m_client/src/lwm2m-client.c Added power management headers and a power-on invocation for the HL78XX modem.
samples/net/cloud/aws_iot_mqtt/src/main.c Added similar power management initialization for the modem in the AWS IoT MQTT sample.
drivers/modem/modem_socket.c Updated POLLOUT event handling with temporary logging and fallback behavior.
drivers/modem/hl78xx/hl78xx_utility.c Added HL78XX utility functions; note an inconsistent module name in the log registration.
drivers/modem/hl78xx/hl78xx.h Introduced declarations and definitions supporting the HL78XX modem driver.
Files not reviewed (6)
  • drivers/modem/CMakeLists.txt: Language not supported
  • drivers/modem/Kconfig: Language not supported
  • drivers/modem/hl78xx/CMakeLists.txt: Language not supported
  • samples/net/cloud/aws_iot_mqtt/boards/hl78xx_chat.conf: Language not supported
  • samples/net/lwm2m_client/Kconfig: Language not supported
  • samples/net/lwm2m_client/overlay-hl78xx_chat.conf: Language not supported
Comments suppressed due to low confidence (1)

drivers/modem/hl78xx/hl78xx_utility.c:18

  • [nitpick] The module name 'hl7812_utility' appears inconsistent with the HL78XX naming convention used elsewhere. Consider renaming it to 'hl78xx_utility' for naming consistency.
LOG_MODULE_REGISTER(hl7812_utility, CONFIG_MODEM_LOG_LEVEL);

@zafersn zafersn force-pushed the hl78xx_driver branch 16 times, most recently from c4e404b to df0f647 Compare May 12, 2025 11:04
@zafersn zafersn marked this pull request as ready for review May 12, 2025 13:10
@zafersn zafersn force-pushed the hl78xx_driver branch 10 times, most recently from b277f96 to 2b34563 Compare June 18, 2025 14:28
zafersn added 5 commits June 21, 2025 19:02
Adding HL78XX Modem Driver Implementation Using Modem Chat Framework

Signed-off-by: Zafer SEN <zafersn93@gmail.com>
Add HL78xx driver sample application

Signed-off-by: Zafer SEN <zafersn93@gmail.com>
add support for HL78xx driver

Signed-off-by: Zafer SEN <zafersn93@gmail.com>
Add support for HL78xx driver

Signed-off-by: Zafer SEN <zafersn93@gmail.com>
add support for HL78xx driver

Signed-off-by: Zafer SEN <zafersn93@gmail.com>
@zafersn zafersn force-pushed the hl78xx_driver branch 6 times, most recently from 28703ae to 08da7fb Compare July 1, 2025 08:33
@kartben kartben added this to the v4.3.0 milestone Jul 1, 2025
@zafersn zafersn force-pushed the hl78xx_driver branch 3 times, most recently from a49f1a6 to 3cae5a4 Compare July 1, 2025 10:39
zafersn added 2 commits July 1, 2025 12:31
Adding Low Power Functionalities

Signed-off-by: Zafer SEN <zafersn93@gmail.com>
Add low power config files

Signed-off-by: Zafer SEN <zafersn93@gmail.com>
Copy link

sonarqubecloud bot commented Jul 1, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants