-
Notifications
You must be signed in to change notification settings - Fork 7.6k
drivers: wifi: nrf7002: Add support for multiple virtual interfaces (… #86618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @hanan619, and thank you very much for your first pull request to the Zephyr project! |
@jukkar @rlezuo1 @MaochenWang1 @sachinthegreen @Kludentwo Can anyone please review this MR and let us know the changes required. We are waiting for thi PR to be verified so that we can integrate it in our application. |
You need to update manifest file |
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
@jukkar west.yml updated with hostap pr. Kindly proceed with review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no merge commits please, use git rebase
over git merge
when rebasing to main
.
I can still see the merge commits in the latest push. |
7d6f275
to
55c2e41
Compare
I would just add it to the |
@krish2718 Please re-run the tests |
Twister is still failing, so, I have not done any manual testing, can you please do below locally and fix any issues before the next push? Once CI is green, I can run my manual tests and we can merge it, thanks.
|
@munir-zin reference |
1b279c7
to
4eccb63
Compare
@krish2718 Please re-run the tests |
7faf4b7
to
f9f1f56
Compare
@krish2718 |
No, two twister Jobs got cancelled, I re-ran them now. |
They are cancelled again |
@hanan619 the problem of jobs getting cancelled is because of the source branch named
Can you please recreate the PR with a different source branch? |
@krish2718 Duplicate PR created with the different source branch |
|
Description:
The nRF7002 firmware supports two virtual interfaces (VIFs) that can operate in different modes (e.g., AP and STA). However, the existing Zephyr driver only utilizes a single VIF, preventing full multi-interface support.
This PR extends the nRF7002 driver to support multiple VIFs by making the following modifications:
Command Response Handling: The UMAC control commands previously did not associate responses with the issuing VIF. A queue is now introduced to track the originating VIF for each command and correctly route the response event to the corresponding interface.Testing:
Verified that two virtual interfaces can be registered and operate simultaneously.
Tested AP mode on one VIF and STA mode on another VIF concurrently.
Ensured that UMAC command responses are correctly matched to their respective VIFs.
Dependencies:
This PR depends on the corresponding hostap PR, which introduces multiple control channels in WPA supplicant to handle separate interfaces.