-
Notifications
You must be signed in to change notification settings - Fork 21
hostap: Add support for multiple interfaces in WPA supplicant #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@jukkar @krish2718 @rlubos Can anyone please review this MR and let us know the changes required. We are waiting for thi PR to be verified so that we can integrate it in our application. |
Where is the relevant manifest update in zephyr size? For example |
Answering to myself, the PR is zephyrproject-rtos/zephyr#86618 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, do you plan to work on the hostapd control interface implementation too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split the commit in to one-commit per logical change and use appropriate tags toup
or noup
, check the git log for references.
@krish2718 |
@@ -700,6 +700,9 @@ struct wpa_supplicant { | |||
unsigned char own_addr[ETH_ALEN]; | |||
unsigned char perm_addr[ETH_ALEN]; | |||
char ifname[100]; | |||
/* wpa_ctrl for each wpa_s */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is implied as the struct is wpa_supplicant.
Sure, I am okay with a single commit, please add a |
@jukkar Do you have any feedback on these changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you don't plan to do the same for hostapd_cli_zephyr.c
?
@jerome-pouiller |
@rlubos |
Approved but my ACK is not the issue here, the PR was likely not merged yet as the corresponding manifest PR (zephyrproject-rtos/zephyr#86618) has still change request on it. |
Description: The current WPA supplicant implementation in Zephyr does not support multiple interfaces because it uses a single global control channel for interface communication. Since each interface (wpa_s instance) operates independently, this limitation prevents proper handling of multiple virtual interfaces (VIFs). This commit modifies WPA supplicant to support multiple interfaces by: * Removing the single global control channel. * Introducing a new ctrl_conn member in the wpa_s structure. * Assigning a separate ctrl_conn for each interface instance, enabling independent communication between WPA supplicant and Zephyr’s network layer. With this change, each virtual interface can now communicate with the control layer independently, allowing the coexistence of multiple VIFs. Signed-off-by: Hanan Arshad <hananarshad619@gmail.com>
Description:
The current WPA supplicant implementation in Zephyr does not support multiple interfaces because it uses a single global control channel for interface communication. Since each interface (wpa_s instance) operates independently, this limitation prevents proper handling of multiple virtual interfaces (VIFs).
With this change, each virtual interface can now communicate with the control layer independently, allowing the coexistence of multiple VIFs.
Testing:
Dependencies:
This change is part of a broader effort to enable multi-VIF support in the nRF7002 driver. A corresponding PR in the Zephyr repository will introduce driver-level changes to utilize this functionality.