-
Notifications
You must be signed in to change notification settings - Fork 7.7k
STM32 EXTI Rework #85508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STM32 EXTI Rework #85508
Conversation
48d57d5
to
4540804
Compare
41c6fe7
to
49f0acc
Compare
@erwango Do you have ability to run all the EXTI/GPIO twister tests for different stm32 SoC on HW for this PR? |
First, a big thanks for addressing this point.
Yes, but we're currently busy with v4.1, so this topic will be addressed in low prio. Then, one observation regarding the whole change. For instance: here is an example of good draft PR: https://github.com/zephyrproject-rtos/zephyr/pull/85135/commits |
@erwango Thanks for the advice. I have a commit-split definitely on my to-do list. I didn't do so, cause I have somehow cyclic dependency:
I hope you see my point. Sure I will split commits - thanks for the reminder ;) |
aa5fc04
to
2e045aa
Compare
…nding integrate intc_exti_stm32 to intc_gpio_stm32 Co-authored-by: Mathieu CHOPLAIN <mathieu.choplain@st.com> Signed-off-by: Alexander Kozhinov <ak.alexander.kozhinov@gmail.com>
integrate EXTI driver Co-authored-by: Mathieu CHOPLAIN <mathieu.choplain@st.com> Signed-off-by: Alexander Kozhinov <ak.alexander.kozhinov@gmail.com>
add nucleo_h745zi_q_stm32h745xx_m7 overlay and config add nucleo_h745zi_q_stm32h745xx_m4 overlay and config Signed-off-by: Alexander Kozhinov <ak.alexander.kozhinov@gmail.com>
add nucleo_h745zi_q_stm32h745xx_m7 overlay add stm32mp257f_ev1_stm32mp257fxx_m33 overlay Signed-off-by: Alexander Kozhinov <ak.alexander.kozhinov@gmail.com>
add exti driver tests for stm32 platform Signed-off-by: Alexander Kozhinov <ak.alexander.kozhinov@gmail.com>
update exti num-lines to depict total number of lines add clocks entry to exti nodes of certain series Signed-off-by: Alexander Kozhinov <ak.alexander.kozhinov@gmail.com>
add APB0 bus Signed-off-by: Alexander Kozhinov <ak.alexander.kozhinov@gmail.com>
add APB3_S bus Signed-off-by: Alexander Kozhinov <ak.alexander.kozhinov@gmail.com>
d8b1ccf
to
91cdbaa
Compare
Following changes were done:
@mathieuchopstm I think, if @erwango agrees with release notes change - you can start HW-farm run again and hopefully last time 😄 |
91cdbaa
to
63afc88
Compare
UPD: Fix spell-check |
OK for test bench with 63afc88 |
Approved as long as the latest PR are squashed ;-) |
f09a0a2
to
f7dbb58
Compare
@erwango squashed @mathieuchopstm Your approve is also mandatory - please take action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove me as co-author from the last commit.
add release note for STM32 EXTI driver Signed-off-by: Alexander Kozhinov <ak.alexander.kozhinov@gmail.com>
f7dbb58
to
2b9e333
Compare
removed |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK on test bench
Rework STM32 Zephyr EXTI driver to be independent from GPIO and compatible with most of the STM32 SoC's.
Addresses the issue #85366
This change introduces updated EXTI interrupt controller supporting interrupt/event lines handling also from peripherals.
The simplest way to test this PR under Linux is to run tests by utilizing following script:
Create a script file:
Copy following content to the script:
NOTE: You may need to change the board name in
board_list
.Run the script:
<zephyr_root_path>/exti_build_test.sh
NOTE: For the
nucleo_g071rb/stm32g071xx
board onlytests/drivers/rtc/rtc_api
in the above script will work. The other tests are missing necessary .overlay files.Running twister for EXTI STM32 test case:
west twister -T "tests/drivers/interrupt_controller/intc_exti_stm32" --vendor st