boards: tcc: topst_vcp45: add Telechips' TOPST-VCP45 board and basic device driver #83136

pooky1004 · 2024-12-18T01:01:35Z

Add vendor-prefix tcc for vendor TELECHIPS INC.
Add support for TCC7045, SoC of TOPST VCP45.
Add device-tree files
Add support for TOPST VCP45 board
Add GPIO driver for tccvcp
Add clock-control driver
Add interrupt-controller driver
Add timer driver
Add serial driver
Add console driver
Add trigger_irq for topst_vcp45

github-actions · 2024-12-18T01:02:15Z

Hello @pooky1004, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

nordicjm · 2024-12-18T08:10:56Z

drivers/interrupt_controller/Kconfig.tic

+		The Telechips Interrupt Controller provides hardware assistance for prioritizing
+		and aggregating the interrupt sources for ARM Cortex-R5 processor cores.


help text indent it 1x tab followed by 2x spaces

fix help text indentation in drivers/interrupt controller/Kconfig.tic file, replace 2x tabs with 1x tab followed by 2x spaces.

nordicjm · 2024-12-18T08:12:55Z

include/zephyr/drivers/clock_control/clock_control_tcc_ccu.h

+
+void vcp_clock_init(void);
+
+long clock_set_pll_rate(signed long id, uint32_t rate);


@stephanosio do we allow long types instead of int?

change signed long and long to int32_t, unsigned long long to uint64_t, and boolean to bool.

nordicjm · 2024-12-18T08:14:03Z

include/zephyr/drivers/clock_control/clock_control_tcc_ccu.h

+
+long clock_set_pll_rate(signed long id, uint32_t rate);
+
+uint32_t clock_get_pll_rate(signed long id);


None of these are documented, doesn't look to be using the zephyr driver class properly @nordic-krch is this acceptable?

include/zephyr/drivers/clock_control contains vendor specific extensions to clock related features so that is ok but definitely it is missing doxygen documentation.

nordicjm · 2024-12-18T08:14:09Z

include/zephyr/drivers/clock_control/clock_control_tcc_ccu.h

+/*
+ * DEFINITIONS
+ *
+ */


Suggested change

/*

* DEFINITIONS

*

*/

nordicjm · 2024-12-18T08:14:22Z

include/zephyr/drivers/clock_control/clock_control_tcc_ccu.h

+/*
+ * FUNCTION PROTOTYPES
+ *
+ */


Suggested change

/*

* FUNCTION PROTOTYPES

*

*/

thee headers can go

nordicjm · 2024-12-18T08:20:02Z

boards/tcc/topst_vcp45/topst_vcp45_defconfig

+
+CONFIG_SYSCON=y
+
+CONFIG_TIMEOUT_64BIT=y


move some configs from boards/tcc/topst_vcp45/topst_vcp45_defconfig to SOC config

nordicjm · 2024-12-18T08:20:05Z

boards/tcc/topst_vcp45/topst_vcp45_defconfig

+# Copyright 2024 Hounjoung Rim <hounjoung@tsnlab.com>
+
+CONFIG_XIP=n
+CONFIG_SRAM_VECTOR_TABLE=y


move some configs from boards/tcc/topst_vcp45/topst_vcp45_defconfig to SOC config

nordicjm · 2024-12-18T08:20:13Z

boards/tcc/topst_vcp45/topst_vcp45_defconfig

+CONFIG_MAX_THREAD_BYTES=3
+CONFIG_THREAD_STACK_INFO=y
+


Suggested change

CONFIG_MAX_THREAD_BYTES=3

CONFIG_THREAD_STACK_INFO=y

change the value of CONFIG_MAX_THREAD_BYTES defined in the boards/tcc/topst_vcp45/topst_vcp45_defconfig file from 3 to 13.

nordicjm · 2024-12-18T08:22:19Z

soc/tcc/tcc7045/linker.ld

+/*
+ * Copyright 2024 Hounjoung Rim <hounjoung@tsnlab.com>
+ *
+ * SPDX-License-Identifier: Apache-2.0


why is this needed and why can't one of the cortex_* ones in tree be used?

Additional settings are needed for REMAP, so I use our own linker.ld file.

Sometimes SoC's needs there own linker.ld file for various reason, and the maintainer or contributor of this should be ready to update when there are changes.

Though if the sole reason in this case is for a REMAP memory section, then I would like to know why this memory region is not defined in devicetree and thereby become available through the use of LINKER_DT_REGIONS(), which also exists in the cortex default linker templates.

Based on this observation, then I also doubt this SoC works with the CMake linker generator.
A basic test of this would simply be to do a build using -DCONFIG_CMAKE_LINKER_GENERATOR=y.
(Haven't tested this PR yet)

nordicjm · 2024-12-18T08:22:55Z

soc/tcc/tcc7045/soc.c

+	unsigned long long rem = 0;
+	unsigned long long b = divisor;
+	unsigned long long d = 1;
+	unsigned long long res = 0;


why can't uint64 be used?

change signed long and long to int32_t, unsigned long long to uint64_t, and boolean to bool.

nordicjm · 2024-12-18T08:23:21Z

soc/tcc/tcc7045/soc.h

+
+int32_t soc_div64_to_32(unsigned long long *pullDividend, uint32_t uiDivisor, uint32_t *puiRem);
+
+typedef unsigned char boolean; /* for use with TRUE/FALSE        */


change signed long and long to int32_t, unsigned long long to uint64_t, and boolean to bool.

nordicjm · 2024-12-18T08:23:41Z

soc/tcc/tcc7045/soc.h

+#ifndef FALSE
+#define FALSE (0U)
+#endif
+
+#ifndef TRUE
+#define TRUE (1U)
+#endif
+
+#ifndef NULL_PTR
+#define NULL_PTR ((void *)0)
+#endif
+
+#ifndef NULL
+#define NULL (0)
+#endif
+
+#ifndef ON
+#define ON  (TRUE)
+#define OFF (FALSE)
+#endif


rruuaanng

I'm glad I didn't arrive too late. As for the preprocessing macros, we should align with Zephyr. Regarding the other header files, I think they also need to be updated, but I won't point them out here.

include/zephyr/dt-bindings/interrupt-controller/tcc-tic.h

rruuaanng

We should now address the other maintainers' comments and get the CI back to normal.
(Maybe I missed some parts, but I need to leave it to others.)

rruuaanng · 2024-12-22T15:22:23Z

include/zephyr/drivers/clock_control/clock_control_tcc_ccu.h

+ * DEFINITIONS
+ */
+
+#define CKC_MHZ(x) (uint32_t)((x) * 1000000)


Please remove it, we have DT_FREQ_M.
(or you can define an alias for it. It can be called CKC_MHZ.)

Edit

This is just a suggestion, DT_FREQ_M is recommended to be used in dts, but I just want to remind you.

delete the unused CKC_MHZ(x) macro defined in the include/zephyr/drivers/clock_control/clock_control_tcc_ccu.h file.

sonarqubecloud · 2025-05-21T07:48:00Z

Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ C)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Add vendor-prefix tcc for vendor TELECHIPS INC., required by TOPST VCP45. Signed-off-by: Hounjoung Rim <hounjoung@tsnlab.com>

Add support for TCC7045, SoC of TOPST VCP45. Signed-off-by: Hounjoung Rim <hounjoung@tsnlab.com>

Add device-tree files, required by TOPST VCP45. The device tree defines hardware details such as the CPU, timers, interrupt controller, flash memory, RAM, clock controller, UART, and GPIOs, providing a clear map of the system's architecture. Signed-off-by: Hounjoung Rim <hounjoung@tsnlab.com>

Add support for TOPST VCP45. Signed-off-by: Hounjoung Rim <hounjoung@tsnlab.com>

Add GPIO driver for tccvcp, required by TOPST VCP45. Signed-off-by: Hounjoung Rim <hounjoung@tsnlab.com>

Add interrupt-controller driver for tic, required by TOPST VCP45. Signed-off-by: Hounjoung Rim <hounjoung@tsnlab.com>

Add timer driver for tcc_vcpttc, required by TOPST VCP45. Signed-off-by: Hounjoung Rim <hounjoung@tsnlab.com>

Add clock-control driver for tccvcp, required by TOPST VCP45. Signed-off-by: Hounjoung Rim <hounjoung@tsnlab.com>

Add serial driver for tccvcp, required by TOPST VCP45. Signed-off-by: Hounjoung Rim <hounjoung@tsnlab.com>

Add console driver for tccvcp, required by TOPST VCP45. Signed-off-by: Hounjoung Rim <hounjoung@tsnlab.com>

add trigger_irq for topst vcp45 to subsys/test/suite/include/zephyr/interrupt util.h file. Signed-off-by: Hounjoung Rim <hounjoung@tsnlab.com>

sonarqubecloud · 2025-07-23T08:20:52Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.7% Duplication on New Code

See analysis details on SonarQube Cloud

stephanosio · 2025-07-23T12:08:08Z

include/zephyr/drivers/interrupt_controller/intc_tic.h

+#include <zephyr/dt-bindings/interrupt-controller/tcc-tic.h>
+#include <zephyr/sys/util_macro.h>
+
+typedef struct tic_distributor {


This looks awful lot like ARM GICv1, if not identical ... Any reason this cannot use the existing GIC driver?

I mean it probably is GICv1, given that the SoC is Cortex-R5.

zephyrbot added area: Timer Timer area: Devicetree area: GPIO area: Clock Control area: Interrupt Controller labels Dec 18, 2024

zephyrbot requested review from andyross, decsny, galak, henrikbrixandersen, mnkp, nordic-krch, rruuaanng and teburd December 18, 2024 01:02

zephyrbot assigned nordic-krch Dec 18, 2024

pooky1004 changed the title ~~Add the Topst vcp45 board and its related basic device drivers~~ [TOPST-VCP45] Telechips' TOPST-VCP45 board added and basic device driver added Dec 18, 2024

pooky1004 changed the title ~~[TOPST-VCP45] Telechips' TOPST-VCP45 board added and basic device driver added~~ boards: tcc: topst_vcp45: add Telechips' TOPST-VCP45 board and basic device driver Dec 18, 2024

decsny previously approved these changes Dec 18, 2024

View reviewed changes

decsny requested review from nordicjm and kartben December 18, 2024 01:57

nordicjm requested changes Dec 18, 2024

View reviewed changes

nordicjm reviewed Dec 18, 2024

View reviewed changes

rruuaanng requested changes Dec 20, 2024

View reviewed changes

include/zephyr/dt-bindings/interrupt-controller/tcc-tic.h Outdated Show resolved Hide resolved

include/zephyr/dt-bindings/interrupt-controller/tcc-tic.h Outdated Show resolved Hide resolved

rruuaanng reviewed Dec 20, 2024

View reviewed changes

include/zephyr/dt-bindings/interrupt-controller/tcc-tic.h Outdated Show resolved Hide resolved

include/zephyr/dt-bindings/interrupt-controller/tcc-tic.h Outdated Show resolved Hide resolved

include/zephyr/dt-bindings/interrupt-controller/tcc-tic.h Outdated Show resolved Hide resolved

pooky1004 dismissed decsny’s stale review via e2ad76b December 20, 2024 15:55

rruuaanng self-requested a review December 22, 2024 15:05

rruuaanng previously approved these changes Dec 22, 2024

View reviewed changes

pooky1004 dismissed rruuaanng’s stale review via 67dec34 December 24, 2024 01:28

zephyrbot added the area: Testsuite Testsuite label Dec 24, 2024

github-actions bot added the area: Console label Apr 29, 2025

pooky1004 force-pushed the topst_vcp45 branch 3 times, most recently from e4be27c to c48382e Compare April 29, 2025 05:52

pooky1004 force-pushed the topst_vcp45 branch from c48382e to 7959507 Compare May 9, 2025 06:14

pooky1004 force-pushed the topst_vcp45 branch 2 times, most recently from 9dbe09a to d47f46f Compare May 21, 2025 07:19

pooky1004 force-pushed the topst_vcp45 branch 5 times, most recently from 6f31d8c to 10c6b0e Compare July 10, 2025 12:37

dts: bindings: add vendor-prefix tcc for vendor TELECHIPS INC.

ccf97c8

Add vendor-prefix tcc for vendor TELECHIPS INC., required by TOPST VCP45. Signed-off-by: Hounjoung Rim <hounjoung@tsnlab.com>

pooky1004 force-pushed the topst_vcp45 branch from 10c6b0e to 6eff5ae Compare July 12, 2025 01:41

pooky1004 force-pushed the topst_vcp45 branch 2 times, most recently from 7229d55 to de156d0 Compare July 21, 2025 23:30

pooky1004 added 10 commits July 23, 2025 16:30

soc: tcc: add support for TCC7045

56f105a

Add support for TCC7045, SoC of TOPST VCP45. Signed-off-by: Hounjoung Rim <hounjoung@tsnlab.com>

board: tcc: add support for TOPST VCP45

6c5ec0a

Add support for TOPST VCP45. Signed-off-by: Hounjoung Rim <hounjoung@tsnlab.com>

drivers: gpio: add tccvcp gpio driver

776ddd6

Add GPIO driver for tccvcp, required by TOPST VCP45. Signed-off-by: Hounjoung Rim <hounjoung@tsnlab.com>

drivers: interrupt_controller: add tic interrupt-controller driver

c806039

Add interrupt-controller driver for tic, required by TOPST VCP45. Signed-off-by: Hounjoung Rim <hounjoung@tsnlab.com>

drivers: timer: add tcc_vcpttc timer driver

30dd9bc

Add timer driver for tcc_vcpttc, required by TOPST VCP45. Signed-off-by: Hounjoung Rim <hounjoung@tsnlab.com>

drivers: clock_control: add tccvcp clock-control driver

e1e4752

Add clock-control driver for tccvcp, required by TOPST VCP45. Signed-off-by: Hounjoung Rim <hounjoung@tsnlab.com>

drivers: serial: add tccvcp serial driver

8e8013a

Add serial driver for tccvcp, required by TOPST VCP45. Signed-off-by: Hounjoung Rim <hounjoung@tsnlab.com>

drivers: console: add tccvcp console driver

09ffb2b

Add console driver for tccvcp, required by TOPST VCP45. Signed-off-by: Hounjoung Rim <hounjoung@tsnlab.com>

drivers: interrupt_controller: subsys: add trigger_irq for topst_vcp45

5884f9c

add trigger_irq for topst vcp45 to subsys/test/suite/include/zephyr/interrupt util.h file. Signed-off-by: Hounjoung Rim <hounjoung@tsnlab.com>

pooky1004 force-pushed the topst_vcp45 branch from de156d0 to 5884f9c Compare July 23, 2025 07:42

stephanosio reviewed Jul 23, 2025

View reviewed changes

		The Telechips Interrupt Controller provides hardware assistance for prioritizing
		and aggregating the interrupt sources for ARM Cortex-R5 processor cores.


		void vcp_clock_init(void);

		long clock_set_pll_rate(signed long id, uint32_t rate);


		long clock_set_pll_rate(signed long id, uint32_t rate);

		uint32_t clock_get_pll_rate(signed long id);


		int32_t soc_div64_to_32(unsigned long long pullDividend, uint32_t uiDivisor, uint32_t puiRem);

		typedef unsigned char boolean; /* for use with TRUE/FALSE */


		CONFIG_SYSCON=y

		CONFIG_TIMEOUT_64BIT=y

boards: tcc: topst_vcp45: add Telechips' TOPST-VCP45 board and basic device driver #83136

Are you sure you want to change the base?

boards: tcc: topst_vcp45: add Telechips' TOPST-VCP45 board and basic device driver #83136

Conversation

pooky1004 commented Dec 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 18, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rruuaanng left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rruuaanng left a comment

Choose a reason for hiding this comment

Uh oh!

rruuaanng Dec 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented May 21, 2025

Quality Gate failed

Uh oh!

sonarqubecloud bot commented Jul 23, 2025

Quality Gate passed

Uh oh!

stephanosio Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

pooky1004 commented Dec 18, 2024 •

edited

Loading

rruuaanng Dec 22, 2024 •

edited

Loading

stephanosio Jul 23, 2025 •

edited

Loading