flash: workaround compiler error with FIH_PANIC #144
Conversation
nashif
force-pushed
the
topic/flash_header
branch
2 times, most recently
from
a1a2fea to
69bfcdc
Compare
Add code_unreachable to satisfy compiler and convince it we do not return in this function. The error we are getting: error: 'noreturn' function does return [-Werror] Signed-off-by: Anas Nashif <anas.nashif@intel.com>
nashif
force-pushed
the
topic/flash_header
branch
from
69bfcdc to
1348d64
Compare
nashif
changed the title
Fix the following warning in cc3xx_init.c
warning: unused variable 'lock_dfa_enabled' [-Wunused-variable]
75 | uint32_t lock_dfa_enabled = dfa_is_supported;
| ^~~~~~~~~~~~~~~~
Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>
Change-Id: I6d6ad2100557b55d4aabdfcdb1ea3b9e2d799b22
(cherry picked from commit e201cb6)
Do not report errors on array-parameter warnings, zephyr does, but in tf-m this is being ignored and requires some significant changes to comply. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
or else we get defined-but-not-used warnings which would turn into errors. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
well, I am not introducing a feature and we need those changes for the 4.2 release. Thats why we have this repo, we should not be waiting for upstream to deal with such issues. One of the changes has another PR which has dependencies on mcuboot and is being submitted as a patch already, not sure how this will be dealt with: |
Of course as I said I don't mean to wait for fixes to be merged upstream. But we do cooperate and contribute upstream, that's the preferred way. We aim to have as little local patches as possible because it's a source of issues. So here ideally I would rather send those commits as upstream PRs and cherry pick them here, no need to even have a review on them yet, but at least we have something to point to for future cleanup.
Hmm not sure either what's the right way to go about this. cc @nordicjm @de-nordic |
well, I am not even sure how to submit those patches and where, most links in the README are dead. Can someone else please (maintainers of this module in Zephyr) do this? those are trivial build related changes. |
|
one of the commits submitted upstream https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/40761 |
I'll take the two remaining commits upstream. |
Both function are not declared in any headers.
Signed-off-by: Anas Nashif anas.nashif@intel.com