tf-m: build: Treat warnings as errors

[ceolin]

Starting in TF-M 2.2.0 there is a build option to treat warnings as errors. Lets use it.

Fixes #90864

[Copilot]

Pull Request Overview

This PR enables the build option to treat warnings as errors in the Trusted Firmware-M module starting with TF-M 2.2.0.

• Enable the CONFIG_TFM_WARNINGS_ARE_ERRORS flag.
• Adjust CMake build settings for the trusted-firmware-m module.

[tomi-font]

This needs TF-M to be updated to 2.2 first?

[dkalowsk]

@ceolin is this a 4.2 change you want to see merged? Or a 4.3 merge?

[nashif]

afaik it should be, we already have 2.2 which this one targets

[dkalowsk]

@nashif it should be but we have seen in the upgrade is that CI does not test all the TF-M and I have concerns that enabling this will slow down the release.

[ceolin]

The feature itself is not a problem. But I have some concerns about CI, if we use CONFIG_COMPILER_WARNINGS_AS_ERRORS there we may have tests failing. As far as I can tell you there are warnings in certain tf-m builds.

[nashif]

interesting, this whole tf-m update thing started becuase of those issues, and they are still there :(

 The following issues were found (showing the top 10 items):
INFO    - 1) sample.kernel.synchronization on actinius_icarus@1.4.0/nrf9160/ns error (Build failure - error: implicit declaration of function 'flash_area_get_sector'; did you mean 'flash_area_get_sectors'? [-Werror=implicit-function-declaration])
INFO    - 2) sample.kernel.synchronization on actinius_icarus@2.0.0/nrf9160/ns error (Build failure - error: implicit declaration of function 'flash_area_get_sector'; did you mean 'flash_area_get_sectors'? [-Werror=implicit-function-declaration])
INFO    - 3) sample.kernel.synchronization on actinius_icarus_bee/nrf9160/ns error (Build failure - error: implicit declaration of function 'flash_area_get_sector'; did you mean 'flash_area_get_sectors'? [-Werror=implicit-function-declaration])
INFO    - 4) sample.kernel.synchronization on actinius_icarus_som/nrf9160/ns error (Build failure - error: implicit declaration of function 'flash_area_get_sector'; did you mean 'flash_area_get_sectors'? [-Werror=implicit-function-declaration])
INFO    - 5) sample.kernel.synchronization on actinius_icarus_som_dk/nrf9160/ns error (Build failure - error: implicit declaration of function 'flash_area_get_sector'; did you mean 'flash_area_get_sectors'? [-Werror=implicit-function-declaration])
INFO    - 6) sample.kernel.synchronization on b_u585i_iot02a/stm32u585xx/ns error (Build failure - error: unused variable 'plat_data_ptr' [-Werror=unused-variable])

[nashif]

53 | Build failure
-- | --
51 | error: implicit declaration of function 'flash_area_get_sector'; did you mean 'flash_area_get_sectors'? [-Werror=implicit-function-declaration]
1 | error: unused variable 'plat_data_ptr' [-Werror=unused-variable]
1 | error: "MBEDTLS_ECP_MAX_BYTES" redefined [-Werror]

[nashif]

ok, now this is associated with a blocker bug

[github-actions]

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
trusted-firmware-m	zephyrproject-rtos/trusted-firmware-m@d38260c (main)	zephyrproject-rtos/trusted-firmware-m#144	zephyrproject-rtos/trusted-firmware-m#144/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud