enable NETC on imx95 Cortex-A55 #571
Conversation
JiafeiPan
commented
Jul 3, 2025
JiafeiPan
commented
- drivers: netc: make the driver to be aarch64 compatible
- mcux-sdk: MIMX9596_ca55: disable FSL_FEATURE_NETC_HAS_ERRATA_051711
- mcux-sdk: MIMX9596_ca55: fix A-Core header file regard of netc struct definition
- fsl_common_arm: Fix comment sign issue on different architectures
mmahadevan108
requested review from
dbaluta,
mmahadevan108,
LaurentiuM1234,
dleach02,
zejiang0jason,
EmilioCBen and
decsny
|
@JiafeiPan , have the changes to the SDK driver been submitted to the SDK team? |
| #if defined(__ARM_ARCH_8A__) /* This macro is ARMv8-A specific */ | ||
| #define __CS "//" | ||
| #else | ||
| #define __CS "@" |
There was a problem hiding this comment.
Hello, because of MISRA C 2012 rule 21.1: https://stackoverflow.com/questions/50696794/misra-c-2012-rule-21-1-macros-starting-with-underscore. We will not use macro name started with underscore.
Also, this file will be included by every SDK file, to make it not conflict with other code, suggest adding prefix, like MCUX_CS. BTW, what is the meaning of CS? thanks.
There was a problem hiding this comment.
CS is comment sign character, so let's change it to be "MCUX_CS", thanks.
|
Except Jason's comments, I am ok with other changes. Thanks. |
|
Thanks for review, will submit the update to SDK NG. |
JiafeiPan
force-pushed
the
develop/imx95-netc
branch
from
1bbcb46 to
b15c20f
Compare
|
The "mcux-sdk: MIMX9596_ca55: fix A-Core header file" is only for Cortex-A core and no need to push it to mcux-sdk NG, the other three patches have been merged into SDK. |
The comment sign character is '//' on ARMv8 AARCH64, however it's '@' on other ARM architectures. So the current definitions of AT_NONCACHEABLE_SECTION_ALIGN and AT_NONCACHEABLE_SECTION will result in the following error on AARCH64. /tmp/cc96AQ7j.s: Assembler messages: /tmp/cc96AQ7j.s:1020: Error: junk at end of line, first unrecognized character is `@' Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> Signed-off-by: Stephane Viau <stephane.viau@nxp.com> Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
NETC driver is not compatible with struct definition, for example will report the following build error like: modules/hal/nxp/mcux/mcux-sdk-ng/drivers/netc/fsl_netc_timer.h:369:20: error: 'ENETC_PF_TMR_Type' has no member named 'TMR_TEVENT' Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
This Errata is not available on i.MX 95. Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
|
@zejiang0jason , please re-review and remove your block if your comment has been addressed. |
