Skip to content

Treat deprecations seriously - deprecation in websockets #5256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Treat deprecations seriously - deprecation in websockets #5256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a7d69e
First off, we see the pipeline
evnchn Oct 10, 2025
d0c18c1
Try use wsproto instead
evnchn Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions nicegui/ui_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,7 @@ def split_args(args: str) -> list[str]:
reload_excludes=split_args(uvicorn_reload_excludes) if reload else None,
reload_dirs=split_args(uvicorn_reload_dirs) if reload else None,
log_level=uvicorn_logging_level,
ws='wsproto',
**kwargs,
)
config.storage_secret = storage_secret
Expand Down
2 changes: 0 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,6 @@ main_file = ""
testpaths = ["tests"]
filterwarnings = [
'error',
'ignore::DeprecationWarning:^websockets\.legacy(\.|$)',
'ignore::DeprecationWarning:^uvicorn\.protocols\.websockets(\.|$)',
"ignore:'asyncio\\.iscoroutinefunction' is deprecated and slated for removal:DeprecationWarning",
]

Expand Down