Treat deprecations seriously - deprecation in websockets #5256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://websockets.readthedocs.io/en/stable/howto/upgrade.html, and we have 5 years to migrate.
The deadline is 2030 so we're 5 years early, but I guess that's better than being late (🤡).
Implementation
WebSocket protocol configuration:
ws
parameter to'wsproto'
when configuring the Uvicorn server innicegui/ui_run.py
auto
(defaults to the websockets legacy) andwebsockets
wsproto
, which is more low-level, we may have performance increase.websockets-sansio
as well.Test configuration cleanup:
websockets.legacy
anduvicorn.protocols.websockets
modules from thefilterwarnings
section inpyproject.toml
, as these are no longer needed.Progress