Pause automation when Kalman Filter uncertainty gets too high #402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation & Implementation
Before, the
AutomationWatcher
was observing the quality of the GNSS signal and paused when it was insufficient or the last measurement was too old.When using a Kalman Filter, this is not the best approach, because it will stop everytime the signal is lost, while the Kalman Filter can work properly for a few meters without GNSS.
With this PR, the
AutomationWatcher
will pause when the xy-uncertainty becomes bigger than 1cm.I chose this value while testing, but we can adjust it later when we gathered more experience with it.
Progress