Skip to content
This repository was archived by the owner on Jun 11, 2025. It is now read-only.

chore: use tracing-susbcriber for logging #44

Merged
merged 2 commits into from
Oct 1, 2024
Merged

chore: use tracing-susbcriber for logging #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8347e90
chore: use tracing-susbcriber for logging
dartdart26 Oct 1, 2024
4586319
Merge branch 'main' into petar/tracing-logging
dartdart26 Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
234 changes: 76 additions & 158 deletions fhevm-engine/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions fhevm-engine/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ members = ["coprocessor", "executor", "fhevm-engine-common"]

[workspace.dependencies]
clap = { version = "4.5", features = ["derive"] }
tokio = { version = "1.0", features = ["rt-multi-thread", "macros"] }
tokio = { version = "1.38.0", features = ["full"] }
prost = "0.13"
tonic = { version = "0.12", features = ["server"] }
bincode = "1.3.3"
Expand All @@ -13,7 +13,8 @@ anyhow = "1.0.86"
daggy = "0.8.0"
serde = "1.0.210"
prometheus = "0.13.4"
log = { version = "0.4.22", features = ["kv"] }
tracing = "0.1.40"
tracing-subscriber = { version = "0.3.18", features = ["fmt", "json"] }

[profile.dev.package.tfhe]
overflow-checks = false
Expand Down
10 changes: 5 additions & 5 deletions fhevm-engine/coprocessor/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ strum = { version = "0.26", features = ["derive"] }
bincode.workspace = true
sha3.workspace = true
prometheus.workspace = true
log.workspace = true
structured-logger = "1.0.3"
tracing.workspace = true
tracing-subscriber.workspace = true
actix-web = "4.9.0"
opentelemetry = "0.25"
opentelemetry-otlp = "0.25"
opentelemetry_sdk = { version = "0.25", features = ["rt-tokio"] }
opentelemetry = "0.25.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we need to specify up to patch version. Cargo.lock tracks the exact version, we could upgrade just with cargo update to newer patch version if needed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I wanted to do it as the other dependencies. Maybe we can move to "x.y" for other ones too in a separate PR. Do we want it for all dependencies?

opentelemetry-otlp = "0.25.0"
opentelemetry_sdk = { version = "0.25.0", features = ["rt-tokio"] }

[dev-dependencies]
testcontainers = "0.21"
Expand Down
Loading