This repository was archived by the owner on Jun 11, 2025. It is now read-only.
chore: use tracing-susbcriber for logging #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update tokio to 1.38.0.
david-zk
approved these changes
Oct 1, 2024
| opentelemetry = "0.25" | ||
| opentelemetry-otlp = "0.25" | ||
| opentelemetry_sdk = { version = "0.25", features = ["rt-tokio"] } | ||
| opentelemetry = "0.25.0" |
There was a problem hiding this comment.
Not sure if we need to specify up to patch version. Cargo.lock tracks the exact version, we could upgrade just with cargo update to newer patch version if needed
There was a problem hiding this comment.
Makes sense. I wanted to do it as the other dependencies. Maybe we can move to "x.y" for other ones too in a separate PR. Do we want it for all dependencies?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tokio to 1.38.0.