Skip to content

Update python app docs #7698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 3, 2024
Merged

Conversation

vgvoleg
Copy link
Collaborator

@vgvoleg vgvoleg commented Aug 13, 2024

Changelog entry

Updated Python App docs using new Query Service SQK
...

Changelog category

  • Documentation (changelog entry is not required)

Additional information

...

@vgvoleg vgvoleg requested a review from a team as a code owner August 13, 2024 09:01
@vgvoleg vgvoleg closed this Aug 13, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 13, 2024
@vgvoleg vgvoleg reopened this Aug 13, 2024
@vgvoleg vgvoleg force-pushed the python_app_docs_updated branch from c44df78 to 82f322d Compare August 13, 2024 12:49
@vgvoleg vgvoleg force-pushed the python_app_docs_updated branch from 82f322d to 3bec858 Compare August 13, 2024 12:52
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Aug 15, 2024
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@vgvoleg vgvoleg force-pushed the python_app_docs_updated branch from 2c3ac74 to 13e0019 Compare August 15, 2024 13:56
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@vgvoleg vgvoleg force-pushed the python_app_docs_updated branch from 13e0019 to fb3bb09 Compare August 15, 2024 14:07
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@vgvoleg vgvoleg force-pushed the python_app_docs_updated branch from fb3bb09 to c6730e1 Compare August 15, 2024 14:15
@vgvoleg vgvoleg changed the title WIP: Update python app docs Update python app docs Aug 15, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Aug 15, 2024
@vgvoleg
Copy link
Collaborator Author

vgvoleg commented Aug 15, 2024

@fomichev3000 @blinkov could you please review RU docs? I'm ready to start update of EN docs but will be happy to have general OK to structure/content

Co-authored-by: Ivan Blinkov <ivan@blinkov.ru>
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@vgvoleg vgvoleg force-pushed the python_app_docs_updated branch from b4675f2 to 15e6f24 Compare August 20, 2024 08:52
Copy link

github-actions bot commented Aug 26, 2024

2024-08-26 11:34:28 UTC Pre-commit check for 9fa5493 has started.
2024-08-26 11:36:42 UTC Check linux-x86_64-release-clang14 is running...
2024-08-26 11:37:22 UTC Check cancelled

Copy link

github-actions bot commented Aug 26, 2024

2024-08-26 11:34:32 UTC Pre-commit check for 9fa5493 has started.
2024-08-26 11:36:46 UTC Check linux-x86_64-release-asan is running...
2024-08-26 11:37:27 UTC Check cancelled

@vgvoleg vgvoleg force-pushed the python_app_docs_updated branch from 1eef358 to d21b7db Compare August 26, 2024 11:37
Copy link

github-actions bot commented Aug 26, 2024

2024-08-26 11:38:50 UTC Pre-commit check for 838e77c has started.
2024-08-26 11:41:14 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-26 11:42:07 UTC Build failed. see the logs.

Copy link

github-actions bot commented Aug 26, 2024

2024-08-26 11:38:51 UTC Pre-commit check for 838e77c has started.
2024-08-26 11:40:58 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-08-26 11:41:49 UTC Build failed. see the logs.

Copy link

❌ Documentation build

Revision build failed

Build logs

Errors (1)

❌ Note must be closed in /ru/dev/example-app/python/index.md

Copy link

github-actions bot commented Aug 26, 2024

2024-08-26 11:40:57 UTC Pre-commit check for 838e77c has started.
2024-08-26 11:43:19 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-26 11:43:59 UTC Build failed. see the logs.

@vgvoleg vgvoleg force-pushed the python_app_docs_updated branch from d21b7db to b781679 Compare August 26, 2024 11:44
Copy link

github-actions bot commented Aug 26, 2024

2024-08-26 11:47:14 UTC Pre-commit check for dc26d06 has started.
2024-08-26 11:49:32 UTC Check linux-x86_64-release-asan is running...
🟢 2024-08-26 11:50:30 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-08-26 11:50:37 UTC Build successful.

Copy link

github-actions bot commented Aug 26, 2024

2024-08-26 11:49:37 UTC Pre-commit check for dc26d06 has started.
2024-08-26 11:52:02 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-26 11:52:09 UTC Build successful.

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Copy link

github-actions bot commented Aug 26, 2024

2024-08-26 11:59:00 UTC Pre-commit check for 167ec67 has started.
2024-08-26 12:01:18 UTC Check linux-x86_64-release-asan is running...
🟢 2024-08-26 12:02:20 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-08-26 12:02:27 UTC Build successful.

Copy link

github-actions bot commented Aug 26, 2024

2024-08-26 12:02:25 UTC Pre-commit check for 167ec67 has started.
2024-08-26 12:05:54 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-26 12:06:03 UTC Build successful.

Copy link

github-actions bot commented Aug 26, 2024

2024-08-26 12:06:27 UTC Pre-commit check for 167ec67 has started.
2024-08-26 12:08:37 UTC Check linux-x86_64-relwithdebinfo is running...
🟢 2024-08-26 12:08:43 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-08-26 12:08:50 UTC Build successful.

@vgvoleg vgvoleg requested a review from blinkov August 26, 2024 13:33
@blinkov blinkov enabled auto-merge (squash) September 3, 2024 03:28
Copy link
Member

@fomichev3000 fomichev3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я Окаю, но:

  1. Я бы явно дописал про sync/async словами. В чем разница, когда что использовать.
  2. Английский местами ужасный, я перестал на нем читать после первых абзацев, кровь из глаз. Мое любимое "Next, from the same working directory, run the command to start the test app. The command will differ depending on the database to connect to."

@blinkov blinkov merged commit 9a0a109 into ydb-platform:main Sep 3, 2024
13 checks passed
KirillKurdyukov pushed a commit to KirillKurdyukov/ydb that referenced this pull request Sep 4, 2024
Co-authored-by: Ivan Blinkov <ivan@ydb.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants