Skip to content

fix(Network): host in default and required columns #2511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

fix(Network): host in default and required columns #2511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/NetworkTable/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export const NETWORK_NODES_TABLE_SELECTED_COLUMNS_KEY = 'networkNodesTableSelect

export const NETWORK_DEFAULT_NODES_COLUMNS: NodesColumnId[] = [
'NodeId',
'Host',
'NetworkHost',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to change column name here

'Connections',
'NetworkUtilization',
'SendThroughput',
Expand All @@ -14,7 +14,7 @@ export const NETWORK_DEFAULT_NODES_COLUMNS: NodesColumnId[] = [
'ClockSkew',
];

export const NETWORK_REQUIRED_NODES_COLUMNS: NodesColumnId[] = ['NodeId'];
export const NETWORK_REQUIRED_NODES_COLUMNS: NodesColumnId[] = ['NodeId', 'NetworkHost'];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NetworkTable default columns do not require SystemState field from backend, so without NetworkHost node will be displayed as unavailable


export const NETWORK_NODES_GROUP_BY_PARAMS = [
'Host',
Expand Down
Loading