fix(Network): host in default and required columns #2511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
commented
Jun 30, 2025
| @@ -14,7 +14,7 @@ export const NETWORK_DEFAULT_NODES_COLUMNS: NodesColumnId[] = [ | |||
| 'ClockSkew', | |||
| ]; | |||
|
|
|||
| export const NETWORK_REQUIRED_NODES_COLUMNS: NodesColumnId[] = ['NodeId']; | |||
| export const NETWORK_REQUIRED_NODES_COLUMNS: NodesColumnId[] = ['NodeId', 'NetworkHost']; | |||
There was a problem hiding this comment.
NetworkTable default columns do not require SystemState field from backend, so without NetworkHost node will be displayed as unavailable
artemmufazalov
commented
Jun 30, 2025
| @@ -5,7 +5,7 @@ export const NETWORK_NODES_TABLE_SELECTED_COLUMNS_KEY = 'networkNodesTableSelect | |||
|
|
|||
| export const NETWORK_DEFAULT_NODES_COLUMNS: NodesColumnId[] = [ | |||
| 'NodeId', | |||
| 'Host', | |||
| 'NetworkHost', | |||
There was a problem hiding this comment.
I forgot to change column name here
astandrik
approved these changes
Jun 30, 2025
Raubzeug
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️3
⏭️ Skipped Tests (3)
Bundle Size: ✅
Current: 84.01 MB | Main: 84.01 MB
Diff: +0.05 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information