Skip to content

fix(knowledgemanagment): removed unsupported files while sending to server #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2025
Merged

fix(knowledgemanagment): removed unsupported files while sending to server #1039

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12d736e
fix: XYNE-94 removed unsupported files while sending to server
rahul1841 Oct 3, 2025
68ba2c5
refactor: XYNE-94 comments resolved
rahul1841 Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 30 additions & 6 deletions frontend/src/routes/_authenticated/knowledgeManagement.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import {
deleteCollection,
deleteItem,
} from "@/utils/fileUtils"
import { isValidFile } from "shared/fileUtils"
import type {
Collection as CollectionType,
CollectionItem,
Expand Down Expand Up @@ -640,6 +641,21 @@ function KnowledgeManagementContent() {
setOpenDropdown(null)
}

// Utility function to filter valid files and show error if none are valid
const getValidFilesOrShowError = (files: FileUploadSelectedFile[]) => {
const validFiles = files.filter(f => isValidFile(f.file))

if (validFiles.length === 0) {
toast.error({
title: "Unsupported Files",
description: "No valid files to upload. All selected files are unsupported.",
})
return null
}

return validFiles
}

const handleUpload = async () => {
if (selectedFiles.length === 0) {
toast.error({
Expand All @@ -662,9 +678,13 @@ function KnowledgeManagementContent() {
return
}

// Start the global upload progress
const batches = createBatches(selectedFiles, collectionName.trim())
const files = selectedFiles.map(f => ({ file: f.file, id: f.id }))
// Filter out unsupported files before upload
const validFiles = getValidFilesOrShowError(selectedFiles)
if (!validFiles) return

// Start the global upload progress with only valid files
const batches = createBatches(validFiles, collectionName.trim())
const files = validFiles.map(f => ({ file: f.file, id: f.id }))
const { uploadId, abortController } = startUpload(collectionName.trim(), files, batches.length, true)

// Close the modal immediately after starting upload
Expand Down Expand Up @@ -858,9 +878,13 @@ function KnowledgeManagementContent() {
return
}

// Start the global upload progress
const batches = createBatches(selectedFiles, addingToCollection.name)
const files = selectedFiles.map(f => ({ file: f.file, id: f.id }))
// Filter out unsupported files before upload
const validFiles = getValidFilesOrShowError(selectedFiles)
if (!validFiles) return

// Start the global upload progress with only valid files
const batches = createBatches(validFiles, addingToCollection.name)
const files = validFiles.map(f => ({ file: f.file, id: f.id }))
const { uploadId, abortController } = startUpload(addingToCollection.name, files, batches.length, false, addingToCollection.id)

// Close the modal immediately after starting upload
Expand Down
Loading