fix(knowledgemanagment): removed unsupported files while sending to server #1039
Conversation
rahul1841
requested review from
devesh-juspay,
junaid-shirur,
kalpadhwaryu,
shivamashtikar and
zereraz
as code owners
Summary of ChangesHello @rahul1841, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the knowledge management file upload functionality by introducing a pre-upload validation step. It ensures that only supported file types are processed for upload, preventing potential issues with unsupported files being sent to the server. The change also improves the user experience by providing immediate feedback if a user attempts to upload only unsupported files. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughAdds pre-upload validation using Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User
participant KM as KnowledgeManagement UI
participant FU as fileUtils.isValidFile
participant UP as Upload Service
participant T as Toast
U->>KM: Select files and initiate upload
KM->>FU: Filter files (isValidFile)
alt No valid files
KM->>T: Show error toast
note over KM,T: Abort upload
else Valid files exist
KM->>KM: Create batches from validFiles
KM->>UP: startUpload(batches from validFiles)
UP-->>KM: Upload results (success/failure)
KM->>T: Show success/error toasts
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧬 Code graph analysis (1)frontend/src/routes/_authenticated/knowledgeManagement.tsx (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses the issue of uploading unsupported files to the server by adding a validation step that filters out invalid files before initiating the upload process. This change enhances the user experience by providing immediate feedback when unsupported files are selected and prevents unnecessary server requests. The code changes include importing the isValidFile function, filtering the selected files, displaying an error toast if no valid files are selected, and modifying the createBatches and startUpload functions to use the filtered list of valid files.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
frontend/src/routes/_authenticated/knowledgeManagement.tsx (1)
666-676: Consider notifying users about partially filtered files.The current implementation only shows an error when all selected files are unsupported. If a user selects 10 files and 3 are unsupported, those 3 are silently filtered out. Consider enhancing the UX by showing a warning toast that lists which specific files were excluded, so users understand what was filtered and why.
Example enhancement:
// Filter out unsupported files before upload const validFiles = selectedFiles.filter(f => isValidFile(f.file)) +const invalidFiles = selectedFiles.filter(f => !isValidFile(f.file)) +if (invalidFiles.length > 0 && validFiles.length > 0) { + toast.warning({ + title: "Some files excluded", + description: `${invalidFiles.length} unsupported file${invalidFiles.length !== 1 ? 's' : ''} excluded from upload.`, + }) +} if (validFiles.length === 0) { toast.error({ title: "Upload Error", description: "No valid files to upload. All selected files are unsupported.", }) return }Also applies to: 874-883
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
frontend/src/routes/_authenticated/knowledgeManagement.tsx(3 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
frontend/src/routes/_authenticated/knowledgeManagement.tsx (1)
server/shared/fileUtils.ts (1)
isValidFile(10-46)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (5)
frontend/src/routes/_authenticated/knowledgeManagement.tsx (5)
40-40: LGTM! Import is correctly added.The import of
isValidFilefrom the shared utilities aligns with the monorepo structure and provides centralized file validation logic.
666-676: LGTM! Validation logic is correct.The pre-upload validation properly filters unsupported files and provides clear user feedback when no valid files remain. The early return prevents unnecessary processing.
679-680: LGTM! Batching correctly uses filtered files.The batching logic properly operates on
validFiles, ensuring only supported files are processed and uploaded. This maintains data consistency throughout the upload flow.
874-883: LGTM! Consistent validation in add-to-collection flow.The validation logic mirrors the main upload flow, ensuring consistent behavior across both entry points. The error handling is appropriate and user-friendly.
886-887: LGTM! Add-to-collection batching is correct.The batching logic is consistent with the main upload flow, using
validFilesto ensure only supported files are processed.
3 participants
Description
Testing
Summary by CodeRabbit