XWIKI-22709: XNotifications should have the alert role #3707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added the `alert` role to xnotifications.
github-actions bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
* Added the `alert` role to xnotifications. (cherry picked from commit 84a3e53)
michitux
pushed a commit
that referenced
this pull request
Dec 16, 2024
* Added the `alert` role to xnotifications. (cherry picked from commit 84a3e53)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-22709
Changes
Description
alertrole to xnotifications.Screenshots & Video
Using browserStack with Chrome 130 + NVDA ->
2024-12-02.15-39-34.mp4
We can see that the content of the xnotifications for saving are now read out.
Executed Tests
None, except manual tests (see above). As far as I could see, the new attribute would not impact any test checking things on this element: https://github.com/search?q=repo%3Axwiki%2Fxwiki-platform%20xnotification&type=code
Expected merging strategy