XWIKI-23101: XWiki Notifications alert too often #4102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed the harmful role from the notifications themselves. The role is already on the container and handles notifying non visual users. * Added comments to avoid repeating the mistake I did in XWIKI-22709
github-actions bot
pushed a commit
that referenced
this pull request
May 5, 2025
* Removed the harmful role from the notifications themselves. The role is already on the container and handles notifying non visual users. * Added comments to avoid repeating the mistake I did in XWIKI-22709 (cherry picked from commit 0838101)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
michitux
pushed a commit
that referenced
this pull request
May 5, 2025
* Removed the harmful role from the notifications themselves. The role is already on the container and handles notifying non visual users. * Added comments to avoid repeating the mistake I did in XWIKI-22709 (cherry picked from commit 0838101)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
Changes
Description
Clarifications
xwiki.bundle.min.js, which makes edits after the first patch more complex. When checking the demo video, it seems I was testing on an unpatched version :/Screenshots & Video
Before the changes:
2025-04-30.10-46-15.mp4
After the changes:
2025-04-30.11-59-12.mp4
Executed Tests
Manual tests only. This is pretty much just a revert of #3707 which did not have any test change and did not create any automated test regression.
Expected merging strategy