fix prefix issue

[Perdixky]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @Perdixky, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a version resolution discrepancy within the gtl package's xmake.lua configuration. By separating URL definitions and introducing a specific alias and version entry for the Git source, it ensures that the xmake build system correctly identifies and utilizes the gtl library when fetched from its Git repository, thereby fixing a 'prefix issue' related to versioning.

Highlights

• URL Configuration Refinement: The add_urls function calls in packages/g/gtl/xmake.lua have been refactored to separate the tarball download URL from the Git repository URL.
• Git Alias Introduction: A specific git alias has been assigned to the Git repository URL for the gtl package, improving clarity and potentially enabling more precise source selection.
• Version Resolution Enhancement: A new version entry, git:1.2.0, has been added to explicitly link the v1.2.0 tag when fetching the gtl package from its Git source, addressing potential prefix-related issues in version identification.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to fix an issue with version prefixes for the gtl package. The change correctly enables fetching from the git source by adding a git-specific version mapping. However, the fix is incomplete as it only covers one version. I've suggested an improvement to apply the fix for all supported versions in a more maintainable way.

[gemini-code-assist]

This correctly maps version 1.2.0 to the v1.2.0 tag for the git source. However, this should be done for all versions, as they all use a v prefix for their git tags. To make installation from git source reliable for all versions and to keep the package definition concise, consider using a loop to define all git-specific versions.

    for _, v in ipairs({"1.2.0", "1.1.8", "1.1.6", "1.1.5", "1.1.4", "1.1.3", "1.1.2", "1.1.1", "1.1.0"}) do
        add_versions("git:" .. v, "v" .. v)
    end

[Willaaaaaaa]

I agree with gemini this time, we should add them all. see: https://github.com/greg7mdp/gtl/tags

[Perdixky]

Ok. I'll add it.

[star-hengxing]

Use?

local versions = {
    ["1.2.0"] = "1547ab78f62725c380f50972f7a49ffd3671ded17a3cb34305da5c953c6ba8e7"
}

for v, hash in pairs(versions) do
    add_versions(v, hash)
    add_versions("git:" .. v, "v" .. v)
end

[Willaaaaaaa]

elegant! nice and simple does the trick!

[star-hengxing]

However, I think writing it like this is sufficient — most packages that use tags starting with 'v' do the same, which allows seamless compatibility with both urls.

    add_urls("https://github.com/greg7mdp/gtl/archive/refs/tags/$(version).tar.gz",
             "https://github.com/greg7mdp/gtl.git")

    add_versions("v1.2.0", "1547ab78f62725c380f50972f7a49ffd3671ded17a3cb34305da5c953c6ba8e7")