Add gtl package.

[Perdixky]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @Perdixky, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the gtl (Greg's Template Library) package, making it available for use and management via xmake. The package is defined as a header-only library, supporting multiple versions, and includes a streamlined CMake-based installation process that optimizes for core library functionality by disabling auxiliary builds like tests and examples. This addition enhances the available set of utilities for projects within the ecosystem.

Highlights

• New Package Definition: A new xmake package for 'gtl' (Greg's Template Library) has been added to the repository.
• Header-Only Library: The gtl package is configured as a header-only library, simplifying its integration into projects.
• Multi-version Support: Multiple versions of the gtl library, along with their respective commit hashes, are now supported.
• CMake-based Installation: The installation process leverages CMake across various platforms, with configurations to disable building tests, examples, and benchmarks.
• Basic Test Included: A post-installation test is included to verify the successful presence of a key header file (gtl/phmap.hpp).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a new package gtl to the repository. The package definition is mostly correct, but I've identified a few areas for improvement. My feedback focuses on improving version string consistency for better maintainability, and enhancing the on_install script for broader platform compatibility and better code style. Addressing these points will make the package more robust and easier to maintain.

[Perdixky]

/gemini review

[gemini-code-assist]

Code Review

This pull request adds a new package for the gtl header-only library. The package definition is mostly correct, but I've found a few areas for improvement. There's some code duplication in the URL definitions that can be refactored. I've also noticed some inconsistent indentation in the on_install block. More importantly, the package is missing the NOMINMAX preprocessor definition for Windows users, which is specified in the original library's build system and can cause compilation issues if omitted. I've provided a suggestion to add this via an on_load hook.

[Perdixky]

/gemini summary

[gemini-code-assist]

Summary of Changes

This pull request introduces the gtl (Greg's Template Library) package into the system via an xmake.lua definition. This allows for easy integration and management of this header-only C++ utility library, streamlining its build process by focusing solely on the core library components and ensuring its availability across projects.

Highlights

• New Package Definition: A new xmake package for 'gtl' (Greg's Template Library) has been added to the repository.
• Header-Only Library: The gtl package is configured as a header-only library, simplifying its integration into projects.
• Multi-version Support: Multiple versions of the gtl library, along with their respective commit hashes, are now supported.
• CMake-based Installation: The installation process leverages CMake, with configurations to disable building tests, examples, and benchmarks, focusing on core library functionality.
• Basic Test Included: A post-installation test is included to verify the successful presence of a key header file (gtl/phmap.hpp).

Changelog

• packages/g/gtl/xmake.lua
  • Added a new xmake package definition for the gtl library.
  • Configured gtl as a header-only library.
  • Specified download URLs and multiple versions with their SHA256 checksums.
  • Defined an on_install function to use CMake for building, explicitly disabling tests, examples, and benchmarks.
  • Included an on_test function to verify the presence of gtl/phmap.hpp.

Activity

• gemini-code-assist[bot] provided an initial summary of the changes.
• Perdixky requested a /gemini review.
• gemini-code-assist[bot] commented on on_install block regarding platform restriction and indentation, providing a suggestion.
• gemini-code-assist[bot] suggested removing the 'v' prefix from version strings for consistency.
• gemini-code-assist[bot] recommended adding an on_load function to define NOMINMAX for Windows platforms to prevent compilation errors.
• gemini-code-assist[bot] suggested defining the version normalization function once to improve maintainability and reduce redundancy.
• gemini-code-assist[bot] pointed out inconsistent indentation in the configs table and recommended using consistent spaces.
• Perdixky requested a /gemini summary.

[Perdixky]

@luadebug Thanks a lot!