CP-38343: xenopsd GC memory RRD stats #772
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forget_client leaks a thread, it doesn't actually tell it to finish or join it, just sets a global variable to None. We do not actually daemonize anymore (we use systemd), so wrap the forget_client call in an `if !daemon'. Signed-off-by: Edwin Török <edvin.torok@citrix.com>
|
Draft PR, also need to move this to the xen-api repo, but opening it here as draft first, because it'll be easier to backport to Havana. |
lindig
approved these changes
Oct 20, 2021
xc/mem_stats.ml
Outdated
| open Gc | ||
|
|
||
| let ocaml_total = | ||
| let f = kib "ocaml_total" "Total OCaml memory used by %s" in |
Based on xapi_stats.ml, but heavily refactored. Signed-off-by: Edwin Török <edvin.torok@citrix.com>
psafont
reviewed
Oct 22, 2021
psafont
reviewed
Oct 22, 2021
* drop unused code * add more constants for fields * rename GcStat.compute* (although interestingly the slow/expensive stat is the imprecise one) * rename slow to expensive * fix dssf parameter Signed-off-by: Edwin Török <edvin.torok@citrix.com>
|
Maybe there is a way to fit this in: the number of used file descriptors would be another useful stat. |
|
Does this PR have a future? Is it still possible to rebase it? |
|
We probably don't care about backports to Havana (or even Yangtze) on this anymore, so I'm moving this to the XAPI repo, I think it was basically half approved. |
|
Moved to xapi-project/xen-api#5522 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 rrds: a quick one every 5s, and a slow one every 2.5m (that does the slower Gc.stat and smaps_rollup query).
I tried to be careful with units, not to mix words and KiB (i.e. always convert everything to KiB before doing arithmetic on them), the old xapi stats was buggy in this regard (and had some hardcoded constants based on word-size=32-bit which is no longer true).