CP-38343: xenopsd: GC and memory RRD stats #5522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should target the perf feature branch, but that one is out-of-date and needs #5523 first |
edwintorok
force-pushed
the
private/edvint/stats3
branch
from
5559e8f to
b203731
Compare
Vincent-lau
reviewed
May 2, 2024
lindig
approved these changes
May 3, 2024
last-genius
reviewed
Jul 11, 2024
edwintorok
force-pushed
the
private/edvint/stats3
branch
2 times, most recently
from
1071f6a to
e2b2eea
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files@@ Coverage Diff @@
## master #5522 +/- ##
========================================
+ Coverage 51.4% 51.8% +0.4%
========================================
Files 13 19 +6
Lines 1928 2586 +658
========================================
+ Hits 991 1341 +350
- Misses 937 1245 +308 see 16 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Based on xapi_stats.ml, but heavily refactored. Signed-off-by: Edwin Török <edvin.torok@citrix.com> (cherry picked from commit 40d3aa7923c7a5c7654d9e83508e52b3b7c3840a) (cherry picked from commit b30f2310e6087ef59c486410f079175bf36aa705)
edwintorok
force-pushed
the
private/edvint/stats3
branch
from
e2b2eea to
b05efa9
Compare
Signed-off-by: Edwin Török <edwin.torok@cloud.com>
last-genius
approved these changes
Sep 10, 2024
Vincent-lau
reviewed
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on xapi_stats.ml, but heavily refactored.
Signed-off-by: Edwin Török edvin.torok@citrix.com
This is xapi-project/xenopsd#772, but I squashed and rebased the 2 commits on top of latest master, and ran
ocamlformat, and fixed some dune warnings.Original commits in xenopsd repo:
(cherry picked from commit 40d3aa7923c7a5c7654d9e83508e52b3b7c3840a)
(cherry picked from commit b30f2310e6087ef59c486410f079175bf36aa705)
So far I've only compile tested this change, hence a draft.