CA-404611: Fix SXM when VM is shut down midway #6246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
A VM's power-state may change during a cross-pool storage migration, as a VM that was originally running may shut down while the disks are being copied (or vice versa). This case is handled, because copying disks can take a very long time. VM metadata is exported and imported into the remote pool after copying has completed, and the VM power-state is used to decide whether to do CPUID checks. Unfortunately, the power-state is currently taken from the DB right at the start if the function, which does not take into account that is may change. Straightforward fix. Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
This is just an additional safety check following the previous commit. Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
psafont
approved these changes
Jan 22, 2025
last-genius
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.