CA-404611: Fix SXM when VM is shut down midway (#6246)

Author: robhoes

ocaml/sdk-gen/csharp/XE_SR_ERRORCODES.xml

@@ -534,6 +534,11 @@
                 <description>A Failure occurred accessing an API object</description>
                 <value>153</value>
         </code>
+        <code>
+                <name>APIProtocolError</name>
+                <description>A protocol error was received when accessing the API</description>
+                <value>154</value>
+        </code>
 
         <!-- Netapp Specific Error codes -->
         <code>

ocaml/xapi/import.ml

@@ -76,7 +76,9 @@ type config = {
 let is_live config =
   match config.import_type with Metadata_import {live; _} -> live | _ -> false
 
-let needs_cpu_check config =
+let needs_cpu_check config vm_record =
+  vm_record.API.vM_power_state <> `Halted
+  &&
   match config.import_type with
   | Metadata_import {check_cpu; _} ->
       check_cpu
@@ -519,7 +521,7 @@ module VM : HandlerTools = struct
         | Replace (_, vm_record) | Clean_import vm_record ->
             if is_live config then
               assert_can_live_import __context vm_record ;
-            ( if needs_cpu_check config then
+            ( if needs_cpu_check config vm_record then
                 let vmm_record =
                   find_in_export
                     (Ref.string_of vm_record.API.vM_metrics)

ocaml/xapi/xapi_vm_migrate.ml

@@ -1194,7 +1194,6 @@ let migrate_send' ~__context ~vm ~dest ~live:_ ~vdi_map ~vif_map ~vgpu_map
      We look at the VDIs of the VM, the VDIs of all of the snapshots, and any
      suspend-image VDIs. *)
   let vm_uuid = Db.VM.get_uuid ~__context ~self:vm in
-  let power_state = Db.VM.get_power_state ~__context ~self:vm in
   let vbds = Db.VM.get_VBDs ~__context ~self:vm in
   let vifs = Db.VM.get_VIFs ~__context ~self:vm in
   let snapshots = Db.VM.get_snapshots ~__context ~self:vm in
@@ -1466,6 +1465,7 @@ let migrate_send' ~__context ~vm ~dest ~live:_ ~vdi_map ~vif_map ~vgpu_map
                 )
                 vgpu_map
             in
+            let power_state = Db.VM.get_power_state ~__context ~self:vm in
             inter_pool_metadata_transfer ~__context ~remote ~vm ~vdi_map
               ~vif_map ~vgpu_map ~dry_run:false ~live:true ~copy
               ~check_cpu:((not force) && power_state <> `Halted)