Skip to content

CI: use new version of codecov action #5734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

psafont
Copy link
Member

@psafont psafont commented Jun 25, 2024

Testing, it's not clear whether this works, or needs some kind of setup in the github side, or codecov side

Upload works, it's the coverage that keeps being wonky

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #5734     +/-   ##
========================================
- Coverage    45.5%   44.8%   -0.7%     
========================================
  Files          13      16      +3     
  Lines        1624    2210    +586     
========================================
+ Hits          739     992    +253     
- Misses        885    1218    +333     

see 8 files with indirect coverage changes

Flag Coverage Δ
python2.7 45.5% <ø> (ø)
python3.11 51.4% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@psafont
Copy link
Member Author

psafont commented Jun 25, 2024

The mysteries of the ever-shifting coverage ...

@psafont psafont marked this pull request as ready for review June 25, 2024 16:28
psafont and others added 2 commits June 26, 2024 16:26
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Copy link
Collaborator

@bernhardkaindl bernhardkaindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Codecov coverage check is passing now:

  • rebased to the latest master branch and
  • merged the .codecov.yml from feature/py3

Maybe we can even back out the merge of the .codecov.yml from feature/py3 now, but I guessed it should not hurt.

@psafont psafont merged commit 5bd9b86 into xapi-project:master Jun 26, 2024
24 checks passed
@psafont psafont deleted the upcodecov branch June 26, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants