-
Notifications
You must be signed in to change notification settings - Fork 9
Remove deprecated, unused actions #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8702a96
Remove deprecated `android_merge_translators_strings` action
mokagio e75be80
Remove deprecated `ios_merge_translators_strings` action
mokagio fdff3ea
Remove deprecated `android_update_metadata` action
mokagio fdc15c4
Add changelog entry regarding deprecation removals
mokagio fa390b6
Remove unused method associated with removed `ios_localize_project`
mokagio fae13ff
Remove unused method associated with `android_update_metadata`
mokagio ac57799
Revert "Remove unused method associated with removed `ios_localize_pr…
mokagio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
106 changes: 0 additions & 106 deletions
106
lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_merge_translators_strings.rb
This file was deleted.
Oops, something went wrong.
52 changes: 0 additions & 52 deletions
52
lib/fastlane/plugin/wpmreleasetoolkit/actions/android/android_update_metadata.rb
This file was deleted.
Oops, something went wrong.
101 changes: 0 additions & 101 deletions
101
lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_merge_translators_strings.rb
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't
ios_localize_project
still used though (not for long, but until we finish our work on the Localization Tooling Modernization and finally migrate all client apps to the new actions)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch! I'm so glad we have code review 😓
I did run the tests after removing this, but I guess it was a naive of just being happy with that given how old this code is.