Skip to content

Remove deprecated, unused actions #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 9, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ _None_

* Removes the `drawText` binary from the gem (instead depending on it being installed via `brew`). Because this update can not be safely applied with no side effects, it's considered a breaking change. [#312]
* When doing Git operations, if no branch is provided, we'll use `trunk` as a default instead of `develop` [#335]
* Remove deprecated `android_merge_translators_strings`, `android_update_metadata`, and `ios_merge_translators_strings` actions [#337]

### New Features

Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -27,26 +27,6 @@ def self.commit_version_bump
)
end
end

# Calls the `tools/update-translations.sh` script from the project repo, then lint them using the provided gradle task
#
# Deprecated. Use the `android_download_translations` action instead.
#
# @env PROJECT_ROOT_FOLDER The path to the git root of the project
# @env PROJECT_NAME The name of the directory containing the project code (especially containing the `build.gradle` file)
#
# @param [String] validate_translation_command The name of the gradle task to run to validate the translations
#
# @todo Remove this once every client has migrated to `android_download_translations` and we got rid of that legacy action.
#
def self.update_metadata(validate_translation_command)
Action.sh('./tools/update-translations.sh')
Action.sh('git', 'submodule', 'update', '--init', '--recursive')
Action.sh('./gradlew', validate_translation_command)

res_dir = File.join(ENV['PROJECT_ROOT_FOLDER'], ENV['PROJECT_NAME'], 'src', 'main', 'res')
Fastlane::Helper::GitHelper.commit(message: 'Update translations', files: res_dir, push: true)
end
end
end
end
Expand Down
85 changes: 0 additions & 85 deletions spec/android_merge_translators_strings_spec.rb

This file was deleted.

Loading