Remove IAP as experimental feature flag option

Modules/Sources/Experiments/DefaultFeatureFlagService.swift

@@ -22,8 +22,6 @@ public struct DefaultFeatureFlagService: FeatureFlagService {
             return buildConfig == .localDeveloper || buildConfig == .alpha
         case .searchProductsBySKU:
             return true
-        case .inAppPurchasesDebugMenu:
-            return buildConfig == .localDeveloper || buildConfig == .alpha
         case .performanceMonitoring,
                 .performanceMonitoringCoreData,
                 .performanceMonitoringFileIO,

Modules/Sources/Experiments/FeatureFlag.swift

@@ -34,11 +34,6 @@ public enum FeatureFlag: Int {
     ///
     case searchProductsBySKU
 
-    /// Makes the Experimental Feature toggle for the Debug In-app purchases menu visible.
-    /// This should not be turned on in production builds. This doesn't make any difference to the availabliity of plan purchases via IAP.
-    ///
-    case inAppPurchasesDebugMenu
-
     /// Enables Tap to Pay on iPhone flow in In-Person Payments, on eligible devices.
     /// This flag needs to be retained, as we cannot enable TTPoI on the Enterprise certificate,
     /// so `.alpha` builds must be excluded.

Modules/Sources/Storage/Model/Copiable/Models+Copiable.generated.swift

@@ -57,7 +57,6 @@ extension Storage.GeneralAppSettings {
         installationDate: NullableCopiableProp<Date> = .copy,
         feedbacks: CopiableProp<[FeedbackType: FeedbackSettings]> = .copy,
         isViewAddOnsSwitchEnabled: CopiableProp<Bool> = .copy,
-        isInAppPurchasesSwitchEnabled: CopiableProp<Bool> = .copy,
         knownCardReaders: CopiableProp<[String]> = .copy,
         lastEligibilityErrorInfo: NullableCopiableProp<EligibilityErrorInfo> = .copy,
         lastJetpackBenefitsBannerDismissedTime: NullableCopiableProp<Date> = .copy,
@@ -69,7 +68,6 @@ extension Storage.GeneralAppSettings {
         let installationDate = installationDate ?? self.installationDate
         let feedbacks = feedbacks ?? self.feedbacks
         let isViewAddOnsSwitchEnabled = isViewAddOnsSwitchEnabled ?? self.isViewAddOnsSwitchEnabled
-        let isInAppPurchasesSwitchEnabled = isInAppPurchasesSwitchEnabled ?? self.isInAppPurchasesSwitchEnabled
         let knownCardReaders = knownCardReaders ?? self.knownCardReaders
         let lastEligibilityErrorInfo = lastEligibilityErrorInfo ?? self.lastEligibilityErrorInfo
         let lastJetpackBenefitsBannerDismissedTime = lastJetpackBenefitsBannerDismissedTime ?? self.lastJetpackBenefitsBannerDismissedTime
@@ -82,7 +80,6 @@ extension Storage.GeneralAppSettings {
             installationDate: installationDate,
             feedbacks: feedbacks,
             isViewAddOnsSwitchEnabled: isViewAddOnsSwitchEnabled,
-            isInAppPurchasesSwitchEnabled: isInAppPurchasesSwitchEnabled,
             knownCardReaders: knownCardReaders,
             lastEligibilityErrorInfo: lastEligibilityErrorInfo,
             lastJetpackBenefitsBannerDismissedTime: lastJetpackBenefitsBannerDismissedTime,

Modules/Sources/Storage/Model/GeneralAppSettings.swift

@@ -24,10 +24,6 @@ public struct GeneralAppSettings: Codable, Equatable, GeneratedCopiable {
     ///
     public var isViewAddOnsSwitchEnabled: Bool
 
-    /// The state for the In-app Purchases feature switch.
-    ///
-    public var isInAppPurchasesSwitchEnabled: Bool
-
     /// A list (possibly empty) of known card reader IDs - i.e. IDs of card readers that should be reconnected to automatically
     /// e.g. ["CHB204909005931"]
     ///
@@ -59,7 +55,6 @@ public struct GeneralAppSettings: Codable, Equatable, GeneratedCopiable {
     public init(installationDate: Date?,
                 feedbacks: [FeedbackType: FeedbackSettings],
                 isViewAddOnsSwitchEnabled: Bool,
-                isInAppPurchasesSwitchEnabled: Bool,
                 knownCardReaders: [String],
                 lastEligibilityErrorInfo: EligibilityErrorInfo? = nil,
                 lastJetpackBenefitsBannerDismissedTime: Date? = nil,
@@ -74,7 +69,6 @@ public struct GeneralAppSettings: Codable, Equatable, GeneratedCopiable {
         self.lastEligibilityErrorInfo = lastEligibilityErrorInfo
         self.lastJetpackBenefitsBannerDismissedTime = lastJetpackBenefitsBannerDismissedTime
         self.featureAnnouncementCampaignSettings = featureAnnouncementCampaignSettings
-        self.isInAppPurchasesSwitchEnabled = isInAppPurchasesSwitchEnabled
         self.sitesWithAtLeastOneIPPTransactionFinished = sitesWithAtLeastOneIPPTransactionFinished
         self.isEUShippingNoticeDismissed = isEUShippingNoticeDismissed
         self.isCustomFieldsTopBannerDismissed = isCustomFieldsTopBannerDismissed
@@ -84,7 +78,6 @@ public struct GeneralAppSettings: Codable, Equatable, GeneratedCopiable {
         .init(installationDate: nil,
               feedbacks: [:],
               isViewAddOnsSwitchEnabled: false,
-              isInAppPurchasesSwitchEnabled: false,
               knownCardReaders: [],
               lastEligibilityErrorInfo: nil,
               featureAnnouncementCampaignSettings: [:],
@@ -114,7 +107,6 @@ public struct GeneralAppSettings: Codable, Equatable, GeneratedCopiable {
             installationDate: installationDate,
             feedbacks: updatedFeedbacks,
             isViewAddOnsSwitchEnabled: isViewAddOnsSwitchEnabled,
-            isInAppPurchasesSwitchEnabled: isInAppPurchasesSwitchEnabled,
             knownCardReaders: knownCardReaders,
             lastEligibilityErrorInfo: lastEligibilityErrorInfo,
             featureAnnouncementCampaignSettings: featureAnnouncementCampaignSettings,
@@ -135,7 +127,6 @@ public struct GeneralAppSettings: Codable, Equatable, GeneratedCopiable {
             installationDate: installationDate,
             feedbacks: feedbacks,
             isViewAddOnsSwitchEnabled: isViewAddOnsSwitchEnabled,
-            isInAppPurchasesSwitchEnabled: isInAppPurchasesSwitchEnabled,
             knownCardReaders: knownCardReaders,
             lastEligibilityErrorInfo: lastEligibilityErrorInfo,
             featureAnnouncementCampaignSettings: updatedSettings,
@@ -156,7 +147,6 @@ extension GeneralAppSettings {
         self.installationDate = try container.decodeIfPresent(Date.self, forKey: .installationDate)
         self.feedbacks = try container.decodeIfPresent([FeedbackType: FeedbackSettings].self, forKey: .feedbacks) ?? [:]
         self.isViewAddOnsSwitchEnabled = try container.decodeIfPresent(Bool.self, forKey: .isViewAddOnsSwitchEnabled) ?? false
-        self.isInAppPurchasesSwitchEnabled = try container.decodeIfPresent(Bool.self, forKey: .isInAppPurchasesSwitchEnabled) ?? false
         self.knownCardReaders = try container.decodeIfPresent([String].self, forKey: .knownCardReaders) ?? []
         self.lastEligibilityErrorInfo = try container.decodeIfPresent(EligibilityErrorInfo.self, forKey: .lastEligibilityErrorInfo)
         self.lastJetpackBenefitsBannerDismissedTime = try container.decodeIfPresent(Date.self, forKey: .lastJetpackBenefitsBannerDismissedTime)

Storage/StorageTests/Model/AppSettings/GeneralAppSettingsTests.swift

@@ -66,7 +66,6 @@ final class GeneralAppSettingsTests: XCTestCase {
         let previousSettings = GeneralAppSettings(installationDate: installationDate,
                                                   feedbacks: feedbackSettings,
                                                   isViewAddOnsSwitchEnabled: true,
-                                                  isInAppPurchasesSwitchEnabled: false,
                                                   knownCardReaders: readers,
                                                   lastEligibilityErrorInfo: eligibilityInfo,
                                                   lastJetpackBenefitsBannerDismissedTime: jetpackBannerDismissedDate,
@@ -103,7 +102,6 @@ private extension GeneralAppSettingsTests {
     func createGeneralAppSettings(installationDate: Date? = nil,
                                   feedbacks: [FeedbackType: FeedbackSettings] = [:],
                                   isViewAddOnsSwitchEnabled: Bool = false,
-                                  isInAppPurchasesSwitchEnabled: Bool = false,
                                   isSwiftUIPaymentsMenuSwitchEnabled: Bool = false,
                                   knownCardReaders: [String] = [],
                                   lastEligibilityErrorInfo: EligibilityErrorInfo? = nil,
@@ -116,7 +114,6 @@ private extension GeneralAppSettingsTests {
         GeneralAppSettings(installationDate: installationDate,
                            feedbacks: feedbacks,
                            isViewAddOnsSwitchEnabled: isViewAddOnsSwitchEnabled,
-                           isInAppPurchasesSwitchEnabled: isInAppPurchasesSwitchEnabled,
                            knownCardReaders: knownCardReaders,
                            lastEligibilityErrorInfo: lastEligibilityErrorInfo,
                            lastJetpackBenefitsBannerDismissedTime: lastJetpackBenefitsBannerDismissedTime,

WooCommerce/Classes/Model/BetaFeature.swift

@@ -5,34 +5,27 @@ import protocol WooFoundation.WooAnalyticsEventPropertyType
 
 enum BetaFeature: String, CaseIterable {
     case viewAddOns
-    case inAppPurchases
 }
 
 extension BetaFeature {
     var title: String {
         switch self {
         case .viewAddOns:
             return Localization.viewAddOnsTitle
-        case .inAppPurchases:
-            return Localization.inAppPurchasesManagementTitle
         }
     }
 
     var description: String {
         switch self {
         case .viewAddOns:
             return Localization.viewAddOnsDescription
-        case .inAppPurchases:
-            return Localization.inAppPurchasesManagementDescription
         }
     }
 
     var settingsKey: WritableKeyPath<GeneralAppSettings, Bool> {
         switch self {
         case .viewAddOns:
             return \.isViewAddOnsSwitchEnabled
-        case .inAppPurchases:
-            return \.isInAppPurchasesSwitchEnabled
         }
     }
 
@@ -42,8 +35,6 @@ extension BetaFeature {
         switch self {
         case .viewAddOns:
             return .settingsBetaFeaturesOrderAddOnsToggled
-        default:
-            return .settingsBetaFeatureToggled
         }
     }
 
@@ -95,12 +86,5 @@ private extension BetaFeature {
         static let viewAddOnsDescription = NSLocalizedString(
             "Test out viewing Order Add-Ons as we get ready to launch",
             comment: "Cell description on the beta features screen to enable the order add-ons feature")
-
-        static let inAppPurchasesManagementTitle = NSLocalizedString(
-            "In-app purchases",
-            comment: "Cell title on beta features screen to enable in-app purchases")
-        static let inAppPurchasesManagementDescription = NSLocalizedString(
-            "Test out in-app purchases as we get ready to launch",
-            comment: "Cell description on beta features screen to enable in-app purchases")
     }
 }

WooCommerce/Classes/ViewRelated/Dashboard/Settings/Beta features/BetaFeaturesConfigurationViewModel.swift

@@ -15,8 +15,6 @@ final class BetaFeaturesConfigurationViewModel: ObservableObject {
             switch betaFeature {
                 case .viewAddOns:
                     return true
-                case .inAppPurchases:
-                    return featureFlagService.isFeatureFlagEnabled(.inAppPurchasesDebugMenu)
             }
         }
     }

WooCommerce/Classes/ViewRelated/Hub Menu/HubMenu.swift

@@ -189,8 +189,6 @@ private extension HubMenu {
                     .navigationTitle(Localization.reviews)
             case .coupons:
                 couponListView
-            case .inAppPurchase:
-                InAppPurchasesDebugView()
             case .subscriptions:
                 SubscriptionsView(viewModel: .init())
             case .customers:

WooCommerce/Classes/ViewRelated/Hub Menu/HubMenuViewModel.swift

@@ -26,7 +26,6 @@ enum HubMenuNavigationDestination: Hashable {
     case inbox
     case reviews
     case coupons
-    case inAppPurchase
     case subscriptions
     case customers
     case reviewDetails(parcel: ProductReviewFromNoteParcel)
@@ -389,10 +388,6 @@ private extension HubMenuViewModel {
             items.append(Inbox())
         }
 
-        if generalAppSettings.betaFeatureEnabled(.inAppPurchases) {
-            items.append(InAppPurchases())
-        }
-
         items.append(Customers())
 
         return items
@@ -699,19 +694,6 @@ extension HubMenuViewModel {
         let navigationDestination: HubMenuNavigationDestination? = .reviews
     }
 
-    struct InAppPurchases: HubMenuItem {
-        static var id = "iap"
-
-        let title: String = "[Debug] IAP"
-        let description: String = "Debug your inApp Purchases"
-        let icon: UIImage = UIImage(systemName: "ladybug.fill")!
-        let iconColor: UIColor = .red
-        let accessibilityIdentifier: String = "menu-iap"
-        let trackingOption: String = "debug-iap"
-        let iconBadge: HubMenuBadgeType? = nil
-        let navigationDestination: HubMenuNavigationDestination? = .inAppPurchase
-    }
-
     struct PointOfSaleEntryPoint: HubMenuItem {
         static var id = "pointOfSale"