Remove IAP as experimental feature flag option #15799
Conversation
iamgabrielma
changed the title
iamgabrielma
added
type: task
|
|
There was a problem hiding this comment.
Works as expected, thanks for cleaning this up!
InAppPurchasesForWPComPlansManager, WPComPlanProduct
If you could check for people with active plans, that would help. I'm not sure whether they can renew now that we've removed the plans from the store, but they might be able to. If so, we'll need to keep that code until everyone drops off.
The debug screen was entirely separate from that, especially by the time we shipped it, so there seems to be very little risk here.
| @@ -568,7 +568,7 @@ final class HubMenuViewModelTests: XCTestCase { | |||
| @MainActor | |||
| func test_navigateToDestination_replaces_navigationPath_with_specified_destination() throws { | |||
| // Given | |||
| let generalAppSettings = try mockGeneralAppSettingsStorage(isInAppPurchaseEnabled: true) | |||
| let generalAppSettings = try mockGeneralAppSettingsStorage() | |||
There was a problem hiding this comment.
Do you still need to pass a mock?
It's fine, arguably good practice... just wondering if the mock is changing the behaviour at all.
There was a problem hiding this comment.
It doesn't seem really needed, by not injecting the mock explicitly the test still passes as uses the Servicelocator's instance as default. It seems a bit better though, as the mock relies on MockInMemoryStorage as well when saving settings.
I personally don't like hiding the dependencies much if can be avoided, is not the first time I found issues with tests not working as expected because were relying on a ServiceLocator as default. I'll leave the mock for now, but I think it could benefit from some refactoring around the init at some point the next time we work in the HubMenuViewModel 👍
Description
General feature flag clean-up. This PR removes the In-App purchases toggle as experimental feature flag for debug builds, and its debug view to test IAP.
I've only tackled the feature flag and debug view in this PR, but most likely there's more cleanup to be done around
InAppPurchasesForWPComPlansManager,WPComPlanProduct, its stores/actions and so on. I have not checked yet if we still have any merchant with one of these plans active from when the feature and upgrade path was actually available.Testing information
[Debug] IAProw in the app settings