Simplify Yosemite into a Swift package - Sources only

[mokagio]

Description

See https://linear.app/a8c/issue/AINFRA-468.

Based on top of #15744 and based off the original work from #15678 .

This first PR moves the Yosemite sources from being a framework to being a Swift package.

Steps to reproduce & Testing information

See green CI. Also check out the prototype build.

Screenshots

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. — N.A.

[dangermattic]

	2 Warnings
⚠️	Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	30604
	Version	PR #15755
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	045d091
	Installation URL	6kgncn9924veg

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[mokagio]

The change from Yosemite.Product to Networking.Product can be explained by noticing that the former is but a typealias for the latter:

woocommerce-ios/Yosemite/Yosemite/Model/Model.swift

Line 91 in b6c2f01

public typealias Product = Networking.Product

[joshheald]

It's probably fine, but pedantry could creep in here.

The WooCommerce target isn't supposed to import from Networking or Storage, but to use Yosemite instead... that's the reason for all the typealiases.

So my only concern is that something using this copy function from the WooCommerce target might not be able to without first importing Networking, which it shouldn't do...

It's often better to make a specific model in Yosemite for use by WooCommerce, instead of proxying the Networking model, and you see that more with newer code... presumably if we did that for these examples, rake generate would sort that out.

Do you know why the output changed here?

[mokagio]

Do you know why the output changed here?

I can't say for certain, but my guess is that it has to do with referencing a list of files as opposed to accessing them through the Xcode project. We obviously cannot use the project now because it's no longer there, and for some reason accessing via the package does not work either, I left some more details in #15702

[mokagio]

So my only concern is that something using this copy function from the WooCommerce target might not be able to without first importing Networking, which it shouldn't do...

I tried this quickly locally and it worked without Networking.

diff --git a/WooCommerce/Classes/ViewRelated/Hub Menu/HubMenuCoordinator.swift b/WooCommerce/Classes/ViewRelated/Hub Menu/HubMenuCoordinator.swift
index d5df7f6d9f..3846b3416b 100644
--- a/WooCommerce/Classes/ViewRelated/Hub Menu/HubMenuCoordinator.swift	
+++ b/WooCommerce/Classes/ViewRelated/Hub Menu/HubMenuCoordinator.swift	
@@ -2,10 +2,7 @@ import Combine
 import Foundation
 import UIKit
 
-import enum Yosemite.ProductReviewAction
-import enum Yosemite.NotificationAction
-import struct Yosemite.ProductReviewFromNoteParcel
-import protocol Yosemite.StoresManager
+import Yosemite
 
 /// Coordinator for the HubMenu tab.
 ///
@@ -120,6 +117,7 @@ final class HubMenuCoordinator {
     }
 
     private func pushReviewDetailsViewController(using parcel: ProductReviewFromNoteParcel) {
+        _ = parcel.copy()
         hubMenuController?.pushReviewDetailsViewController(using: parcel)
     }
 }

[mokagio]

The WooCommerce target isn't supposed to import from Networking or Storage, but to use Yosemite instead...

By the way, this rule has been breached a few times:

[joshheald]

This one looks good as well. Tested on simulators, but I'll check on a device when I get a chance too.

[joshheald]

It's probably fine, but pedantry could creep in here.

The WooCommerce target isn't supposed to import from Networking or Storage, but to use Yosemite instead... that's the reason for all the typealiases.

So my only concern is that something using this copy function from the WooCommerce target might not be able to without first importing Networking, which it shouldn't do...

It's often better to make a specific model in Yosemite for use by WooCommerce, instead of proxying the Networking model, and you see that more with newer code... presumably if we did that for these examples, rake generate would sort that out.

Do you know why the output changed here?

[joshheald]

It's surprising to see this one imported in Yosemite... but I see it's needed for UIImage. I guess we got this import for free before...

[mokagio]

Yes. It came from the umbrella header:

woocommerce-ios/Yosemite/Yosemite/Yosemite.h

Line 1 in e94edaa

#import <UIKit/UIKit.h>