Skip to content

Simplify Fakes into a Swift package #15772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025
Merged

Simplify Fakes into a Swift package #15772

merged 1 commit into from
Jun 20, 2025

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Jun 18, 2025

Description

See https://linear.app/a8c/issue/AINFRA-473.

Based on top of #15755 and based off the original work from #15678 .

This first PR moves Fakes from being a framework to being a Swift package. Notice that this framework has no tests because it consists of a protocol, and helper, and generated files.

Steps to reproduce & Testing information

See green CI.


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. — N.A.

@dangermattic
Copy link
Collaborator

dangermattic commented Jun 18, 2025

2 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@mokagio mokagio changed the title AINFRA-470 - Make Networking into a Swift package - Sources only Simplify Fakes into a Swift package Jun 18, 2025
@mokagio mokagio force-pushed the ainfra-473-fakes branch 2 times, most recently from e3dbdbe to 4f9ecd6 Compare June 18, 2025 03:53
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jun 18, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Number30605
VersionPR #15772
Bundle IDcom.automattic.alpha.woocommerce
Commitfd9f830
Installation URL09ngqgbf2ohe8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@mokagio mokagio force-pushed the ainfra-468-yosemite-sources branch from 2c04a26 to 5a1e7e9 Compare June 18, 2025 11:00
@mokagio mokagio force-pushed the ainfra-473-fakes branch from 4f9ecd6 to 4a2047f Compare June 18, 2025 11:01
@mokagio mokagio force-pushed the ainfra-468-yosemite-sources branch from 5a1e7e9 to 284c9fc Compare June 19, 2025 07:12
@mokagio mokagio force-pushed the ainfra-473-fakes branch from 4a2047f to 4aaa07d Compare June 19, 2025 07:16
Copy link
Contributor

@joshheald joshheald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks again @mokagio! Tested generation puts the files in the right places too.

@mokagio mokagio force-pushed the ainfra-468-yosemite-sources branch from 284c9fc to 045d091 Compare June 20, 2025 01:31
@mokagio mokagio force-pushed the ainfra-473-fakes branch from 4aaa07d to fd9f830 Compare June 20, 2025 01:32
@mokagio mokagio added this to the 22.7 milestone Jun 20, 2025
@mokagio mokagio self-assigned this Jun 20, 2025
@mokagio mokagio added the category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. label Jun 20, 2025
@mokagio mokagio marked this pull request as ready for review June 20, 2025 01:35
Base automatically changed from ainfra-468-yosemite-sources to trunk June 20, 2025 01:52
@mokagio mokagio merged commit 6829904 into trunk Jun 20, 2025
20 checks passed
@mokagio mokagio deleted the ainfra-473-fakes branch June 20, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants