Skip to content

[Min-Max Quantities Edit Support] Tracking #11752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

toupper
Copy link
Contributor

@toupper toupper commented Jun 20, 2024

Closes: #11748

Description

With this PR we implement tracking for the Min/Max Quantities Edit Support.

Testing instructions

Product

  1. Go to the Products tab
  2. Tap on a product with Quantity Rules
  3. Tap on the Quantity Rules row.
  4. Tap on Done with and without changing data. This event has to be tracked:
product_detail_quantity_rules_done_button_tapped
has_changed_data: true|false

has_changed_data reflects whether we changed data

Product Variation

  1. Go to the Products tab
  2. Tap on a product with variations
  3. Navigate to a variation with Quantity Rules
  4. Tap on the Quantity Rules row.
  5. Tap on Done with and without changing data. This event has to be tracked:
product_variation_quantity_rules_done_button_tapped
has_changed_data: true|false

has_changed_data reflects whether we changed data

Screenshots


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@toupper toupper added type: task An internally driven task. feature: analytics In-app store analytics labels Jun 20, 2024
@toupper toupper added this to the 19.2 milestone Jun 20, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Jun 20, 2024

1 Message
📖

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

@toupper toupper mentioned this pull request Jun 20, 2024
1 task
@toupper toupper added the category: tracks Related to analytics, including Tracks Events. label Jun 20, 2024
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit5cd7980
Direct Downloadwoocommerce-prototype-build-pr11752-5cd7980.apk

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 28.57143% with 15 lines in your changes missing coverage. Please review.

Project coverage is 40.26%. Comparing base (b457297) to head (5cd7980).
Report is 38 commits behind head on min-max-quantities-edit-support-main-branch.

Files Patch % Lines
...rce/android/ui/products/ProductNavigationTarget.kt 0.00% 4 Missing ⚠️
...i/products/variations/VariationNavigationTarget.kt 0.00% 4 Missing ⚠️
...droid/ui/products/variations/VariationNavigator.kt 0.00% 3 Missing ⚠️
...oocommerce/android/ui/products/ProductNavigator.kt 0.00% 2 Missing ⚠️
...id/ui/products/details/ProductDetailCardBuilder.kt 0.00% 1 Missing ⚠️
.../products/variations/VariationDetailCardBuilder.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                              Coverage Diff                               @@
##             min-max-quantities-edit-support-main-branch   #11752   +/-   ##
==============================================================================
  Coverage                                          40.25%   40.26%           
- Complexity                                          5338     5341    +3     
==============================================================================
  Files                                               1131     1131           
  Lines                                              65297    65312   +15     
  Branches                                            9054     9055    +1     
==============================================================================
+ Hits                                               26287    26299   +12     
- Misses                                             36579    36584    +5     
+ Partials                                            2431     2429    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@toupper toupper merged commit da9ada8 into min-max-quantities-edit-support-main-branch Jun 20, 2024
14 checks passed
@toupper toupper deleted the issue/11748-min-max-quantities-edit-support-tracking branch June 20, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tracks Related to analytics, including Tracks Events. feature: analytics In-app store analytics type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants