Skip to content

[Min-Max Quantities] Main Feature #11753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jun 20, 2024

Conversation

toupper
Copy link
Contributor

@toupper toupper commented Jun 20, 2024

This PR contains these previous PRs:

#11752
#11742

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

toupper added 22 commits June 4, 2024 12:00
…ssue/11655-min-max-quantities-ui

# Conflicts:
#	WooCommerce/src/test/kotlin/com/woocommerce/android/ui/products/variations/GetProductVariationQuantityRulesTest.kt
…ties-ui

[Min/Max Quantities] Edit Support Core Implementation
@toupper toupper added type: task An internally driven task. feature: product details Related to adding or editing products, includes product settings. category: woo extensions Related to WC extensions or plugins. labels Jun 20, 2024
@toupper toupper added this to the 19.2 milestone Jun 20, 2024
@toupper toupper changed the title Min max quantities edit support main branch [Min-Max Quantities] Main Feature Jun 20, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Jun 20, 2024

2 Warnings
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ This PR is assigned to the milestone 19.2. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.
1 Message
📖

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jun 20, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit56c100a
Direct Downloadwoocommerce-prototype-build-pr11753-56c100a.apk

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 63.15789% with 28 lines in your changes missing coverage. Please review.

Project coverage is 40.24%. Comparing base (a8b3bb4) to head (56c100a).

Files Patch % Lines
...rce/android/ui/products/ProductNavigationTarget.kt 0.00% 4 Missing ⚠️
...roid/ui/products/details/ProductDetailViewModel.kt 55.55% 0 Missing and 4 partials ⚠️
...ui/products/variations/VariationDetailViewModel.kt 50.00% 0 Missing and 4 partials ⚠️
...i/products/variations/VariationNavigationTarget.kt 0.00% 4 Missing ⚠️
...in/kotlin/com/woocommerce/android/model/Product.kt 0.00% 0 Missing and 3 partials ⚠️
...droid/ui/products/variations/VariationNavigator.kt 0.00% 3 Missing ⚠️
...oocommerce/android/ui/products/ProductNavigator.kt 0.00% 2 Missing ⚠️
...cts/quantityRules/ProductQuantityRulesViewModel.kt 94.11% 2 Missing ⚠️
...id/ui/products/details/ProductDetailCardBuilder.kt 50.00% 1 Missing ⚠️
.../products/variations/VariationDetailCardBuilder.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #11753      +/-   ##
============================================
+ Coverage     40.21%   40.24%   +0.02%     
- Complexity     5331     5341      +10     
============================================
  Files          1132     1131       -1     
  Lines         65336    65360      +24     
  Branches       9059     9058       -1     
============================================
+ Hits          26276    26302      +26     
+ Misses        36637    36627      -10     
- Partials       2423     2431       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ties-edit-support-tracking

[Min-Max Quantities Edit Support] Tracking
@toupper toupper added the category: tracks Related to analytics, including Tracks Events. label Jun 20, 2024
@toupper toupper merged commit eb98260 into trunk Jun 20, 2024
14 checks passed
@toupper toupper deleted the min-max-quantities-edit-support-main-branch branch June 20, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tracks Related to analytics, including Tracks Events. category: woo extensions Related to WC extensions or plugins. feature: product details Related to adding or editing products, includes product settings. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants