Skip to content

docs: update remote deployment docs with working nginx-install example #2625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025

Conversation

extua
Copy link
Contributor

@extua extua commented May 27, 2025

Update the docs on k3s deployment for installing ingress-nginx, fixes #2619.

Also fix the indentation on the code blocks so markdown carries on list numbering.
At the moment the numbering confusingly resets after point 3.

Screenshot 2025-05-27 at 11-43-21 Remote Self-Hosted and Cloud - Browsertrix Docs

extua added 2 commits May 27, 2025 10:57
plus minor style changes for readability, carriage return at the end of a line with a sentence
…ng ingress-nginx, fixes webrecorder#2619

plus style change to indent code blocks which forces markdown to continue multi-line list items
@extua extua changed the title docs: update remote deployment docs with working nginx-install example, fixes #2619 docs: update remote deployment docs with working nginx-install example May 27, 2025
@extua
Copy link
Contributor Author

extua commented May 27, 2025

Note when merging this partly over-writes #1571

@ikreymer
Copy link
Member

Thanks for the update!

@ikreymer ikreymer force-pushed the doc-change-nginx-deployment branch from 2f0edce to 9fd1a3b Compare May 29, 2025 03:03
@ikreymer
Copy link
Member

Turns out the inline code block has to be indented at least one space to show up indented, so added more spaces there.
Also added link to https://k3s.io/

@ikreymer ikreymer merged commit 8b54444 into webrecorder:main May 29, 2025
4 checks passed
@extua extua deleted the doc-change-nginx-deployment branch May 29, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: Repo not found on helm install of nginx
2 participants