-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
ask-the-documents
: Add CI testing
#3250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fb19c24
to
8dd3092
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ask-the-documents
: Add CI testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question
|
||
/* Run your local dev server before starting the tests */ | ||
webServer: { | ||
command: `run-wasp-app ${WASP_RUN_MODE} --path-to-app=../ --wasp-cli-cmd=${WASP_CLI_CMD} --db-image pgvector/pgvector:pg17`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
test("shows the search bar", async ({ page }) => { | ||
await page.goto("/"); | ||
await page.waitForSelector("input[type='search']"); | ||
await expect(page.locator("input[type='search']")).toBeVisible(); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would need to happen for us to be able to test:
- logging in with Google
- scraping some website
- search
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'd need either some framework-level way of mocking external services, or come up with a solution to MitM the HTTP connections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, it's either mock the whole Google flow or actually log in which might be problematic due to some anti-bot measures. Hm, so MitM sounds the most reliable way of it to me 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's encode this in a existing or a new issue and link back to this file / PR.
I think this is enough for now 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8dd3092
to
f9fccfb
Compare
0d7e6e7
to
bd81e2d
Compare
f9fccfb
to
f88f861
Compare
ask-the-documents
example app in the Wasp monorepo #3141Adds a simple E2E test. Due to it using Google login and OpenAI as core app functionality, right now I'm only testing that it loads and shows the searchbox.
We don't need to use the custom DB commands as
wasp-app-runner
has support for the--db-image
argument.PR hierarchy:
ask-the-documents
: Import app into repo #3174 just imports the repo and runs prettier on itask-the-documents
: Add dotenv files #3252 adds dotenv files with the config that was on railwayask-the-documents
: Deploy to Fly #3251 adds deployment to Fly in CIask-the-documents
: Add CI testing #3250 (👈 this one) adds simple e2e testing to CI